Fix docker build + FE test #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apata
reviewed
Jan 2, 2025
| @@ -20,8 +20,7 @@ RUN mkdir /app | |||
| WORKDIR /app | |||
|
|
|||
| # install build dependencies | |||
| RUN apk add --no-cache git nodejs yarn python3 npm ca-certificates wget gnupg make gcc libc-dev brotli && \ | |||
| npm install npm@latest -g | |||
| RUN apk add --no-cache git nodejs yarn python3 npm ca-certificates wget gnupg make gcc libc-dev brotli | |||
There was a problem hiding this comment.
As a hotfix, what you propose seems good!
However, I think best practice would be to build also in the container with the version we're using locally (as defined in .tool-versions and read in various worfklows using the version output by marocchino/tool-versions-action).
There was a problem hiding this comment.
Makes sense! In that case we'll need to install node from a source other than apk. I'll merge this one to unblock others and find a solution to use the node version from .tool-versions.
apata
approved these changes
Jan 2, 2025
RobertJoonas
force-pushed
the
fix-docker-build
branch
from
880804f to
5842eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
build-private-images.yml.