Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin nodejs version to be the same as .tool-versions #4945

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jan 7, 2025

Proposed follow-up to #4933

Alpine index only exposes a single version of nodejs, which this PR now explicitly pins against. See also: https://pkgs.alpinelinux.org/packages?name=nodejs-current&branch=v3.20&repo=&arch=x86_64&origin=&flagged=&maintainer=

@macobo macobo added the preview label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Preview environment👷🏼‍♀️🏗️
PR-4945

@macobo macobo changed the title Pin nodejs version to be the same as .tool-versions [WIP] Pin nodejs version to be the same as .tool-versions Jan 7, 2025
@macobo macobo marked this pull request as ready for review January 7, 2025 12:18
@macobo macobo requested a review from RobertJoonas January 7, 2025 12:18
Copy link
Contributor

@RobertJoonas RobertJoonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I should have searched Alpine packages by nodejs* 🙈

This sounds like a good fix to me, thanks! Whoever updates node in the future needs to be mindful anyway, so not a big deal if it's not automatically read from the .tool-versions.

@macobo macobo added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit a3241c2 Jan 8, 2025
8 checks passed
@ukutaht ukutaht deleted the pinned-nodejs branch January 8, 2025 10:24
@macobo macobo changed the title [WIP] Pin nodejs version to be the same as .tool-versions Pin nodejs version to be the same as .tool-versions Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants