php 8.2 compatibility #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hej @rbro, thanks for your PR. The proposed change breaks the build with PHP versions 8.0 and 8.1, doesn't it? |
|
Yes, thanks, good point. I'm not familiar with PHP extensions to know how to have a return type of a function be different based on PHP version. Is there a way to do that? |
|
Sorry for the late response. You can achieve this using C++ preprocessor directives like #if PHP_VERSION_ID < 80200
static int v8js_v8object_get_closure
#else
static zend_result v8js_v8object_get_closure
#endif |
stesie
added a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #492. With this change, I'm able to get a clean compile of v8js in PHP 8.2. The change is documented in https://github.com/php/php-src/blob/PHP-8.2/UPGRADING.INTERNALS.