Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8.2 support #492

Closed
rbro opened this issue Nov 5, 2022 · 1 comment
Closed

php 8.2 support #492

rbro opened this issue Nov 5, 2022 · 1 comment

Comments

@rbro
Copy link
Contributor

rbro commented Nov 5, 2022

Thanks for your help in getting v8js compatible with PHP 8 earlier this year. All has been working great for me in both PHP 8 and 8.1. Since PHP 8.2 will be out soon, I decided to try compiling v8js against PHP 8.2.0 RC5, but I'm getting the below compile error.

Appreciate any help you can provide to make v8js compatible with PHP 8.2.

/tmp/v8js/v8js_v8object_class.cc: In function ‘zend_result zm_startup_v8js_v8object_class(int, int)’:
/tmp/v8js/v8js_v8object_class.cc:924:46: error: invalid conversion from ‘int (*)(zend_object*, zend_class_entry**, zend_function**, zend_object**, bool)’ {aka ‘int (*)(_zend_object*, _zend_class_entry**, _zend_function**, _zend_object**, bool)’} to ‘zend_object_get_closure_t’ {aka ‘ZEND_RESULT_CODE (*)(_zend_object*, _zend_class_entry**, _zend_function**, _zend_object**, bool)’} [-fpermissive]
  924 |         v8js_v8object_handlers.get_closure = v8js_v8object_get_closure;
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                              |
      |                                              int (*)(zend_object*, zend_class_entry**, zend_function**, zend_object**, bool) {aka int (*)(_zend_object*, _zend_class_entry**, _zend_function**, _zend_object**, bool)}
make: *** [Makefile:257: v8js_v8object_class.lo] Error 1
@rbro
Copy link
Contributor Author

rbro commented Dec 17, 2022

I added PR #493 which allowed me to compile v8js against PHP 8.2.

@stesie stesie closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants