Use Isolate-version of ScriptOrigin constructor #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stesie
force-pushed
the
script-origin-with-isolate
branch
from
b8e8e6d to
7247e9f
Compare
|
Rebased this PR so PHP 7.4 also profits from it. fixes #488 |
|
@stesie i've not tried yet, but does V8Js work fully with V8 10+ otherwise? |
|
@redbullmarky I've tried with 10.1.124.12 yesterday (with these changes here + php8.1) and it worked just fine. Tested on MacOS w/ arm64 (M1 chip) After all two tests failed, amongst it the new timezone test, which produced "slightly" different output there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new constructor was introduced with V8 9.0 and e.g. 10.1 doesn't have the old one any longer.
So in order to support 10.x versions we have to support the new version. And since 9.0 is pretty old already I've decided not to support both, but drop support for version < 9.0