Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation problems with v8 6.8 #464

Closed
rtlprmft opened this issue Mar 23, 2021 · 1 comment
Closed

Compilation problems with v8 6.8 #464

rtlprmft opened this issue Mar 23, 2021 · 1 comment

Comments

@rtlprmft
Copy link

During compilation, I get a lot of issues because BooleanValue takes isolate as an argument instead of v8_context and once replaced, it returns a Maybey rather than a bool that first have to be checked for contents. I also had to fix some other minor issues.

This happens with the nodejs-dev package on Ubunu 20.04 which contains v8 6.8.

After my fixes, still some tests fail (see attachment), most of them because they return int(0) and int(1) rather than bool(false) and bool(true)

executeString() and register*() seg fault. I am not sure whether this is related. For all other tests, I checked that it is the previously mentioned issue.

I attach the full report
php_test_results_20210322_1102.txt

I also attach a diff with the required changes to make it compile.
v8js.txt

@redbullmarky
Copy link
Collaborator

Closing this one as #486 bumps the minimum V8 version to 9+

@redbullmarky redbullmarky closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants