-
Notifications
You must be signed in to change notification settings - Fork 829
Simplifiying the "A simple tutorial" page #4953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplifiying the "A simple tutorial" page #4953
Conversation
… and MySQL pre-requisites and using php's builtin server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have some comments, but this definitely looks like an improvement to me.
Co-authored-by: Tim Düsterhus <[email protected]>
Co-authored-by: Tim Düsterhus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Given the prominent spot of this page, I'd like to see another approval before merging.
| <para> | ||
| <example> | ||
| <info><title>Our first PHP script: <filename>hello.php</filename></title></info> | ||
| <programlisting role="php"> | ||
| <![CDATA[ | ||
| <?php | ||
| echo "Hello World!"; | ||
| ?> | ||
| ]]> | ||
| </programlisting> | ||
| <simpara> | ||
| Using your terminal, navigate to the directory containing this file and | ||
| start a development server with the following command: | ||
| </simpara> | ||
| <programlisting role="shell"> | ||
| <![CDATA[ | ||
| php -S localhost:8000 | ||
| ]]> | ||
| </programlisting> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the "example" tag+title even provide any benefit?
Maybe just moving all of it into the normal flow is better? But I don't have strong opinions about this and the new text is an improvement over the current one.
Simplifiying the "A simple tutorial" page by removing the Apache and MySQL pre-requisites and using php's builtin server