Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12429 Use a configuration file for mockery #2621

Merged
merged 9 commits into from
Nov 16, 2023

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Nov 14, 2023

PMM-12429

Note: this is intentionally a v3 ticket so we don't have to solve conflicts.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2d491d) 44.05% compared to head (4db7ea0) 43.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2621      +/-   ##
==========================================
- Coverage   44.05%   43.98%   -0.08%     
==========================================
  Files         358      358              
  Lines       41891    41891              
==========================================
- Hits        18455    18424      -31     
- Misses      21845    21875      +30     
- Partials     1591     1592       +1     
Flag Coverage Δ
admin 10.45% <ø> (ø)
agent 53.31% <ø> (-0.29%) ⬇️
managed 45.71% <ø> (ø)
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff force-pushed the PMM-12429-mockery-use-config-file branch from d0b5bf7 to c8fad1d Compare November 14, 2023 09:51
@ademidoff ademidoff force-pushed the PMM-12429-mockery-use-config-file branch from b8e5197 to 9facc99 Compare November 14, 2023 11:01
@ademidoff ademidoff marked this pull request as ready for review November 14, 2023 18:52
@ademidoff ademidoff requested review from idoqo and a team as code owners November 14, 2023 18:52
@ademidoff ademidoff requested review from BupycHuk, JiriCtvrtka and artemgavrilov and removed request for a team November 14, 2023 18:52
@ademidoff ademidoff changed the title PMM-12429 mockery use configuration file PMM-12429 Use a configuration file for mockery Nov 14, 2023
@@ -0,0 +1,110 @@
# This is the top-level configuration file for mockery.
disable-version-string: True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥👍

@ademidoff ademidoff merged commit 4c16ec2 into v3 Nov 16, 2023
@ademidoff ademidoff deleted the PMM-12429-mockery-use-config-file branch November 16, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants