PMM-12429 Use a configuration file for mockery (v2) #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
- Coverage 42.22% 42.03% -0.20%
==========================================
Files 396 399 +3
Lines 50120 50316 +196
==========================================
- Hits 21165 21149 -16
- Misses 26951 27163 +212
Partials 2004 2004
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
requested review from
a team,
BupycHuk,
talhabinrizwan and
idoqo
as code owners
JiriCtvrtka
approved these changes
Feb 23, 2024
BupycHuk
approved these changes
Feb 26, 2024
|
@ademidoff since it's upgrade to Go 1.22.0, could you please create FB? |
Sure! Just launched the FB, will update here once I'm able to test it. Update: the instance seems to work OK, and the API tests pass as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12429
SUBMODULES-3561
It's cherry-picked from v3 to v2.
The motivation was born out of the fact that dependabot would continue to make PRs to upgrade mockery; without migration the interfaces continue to bear the mockery version, which conflicts with v3, where the interface files are already unversioned.
Based on the above, this PR should make it less challenging to merge upgrades.
This PR also bumps up Go to v1.22 as
mockery v2.42.0doesn't compile w/o it.It should close #2836.