Simple sender validation #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmnnd
force-pushed
the
main
branch
2 times, most recently
from
ece9bc2 to
1479070
Compare
wmnnd
force-pushed
the
main
branch
3 times, most recently
from
f9c8f47 to
1ed442b
Compare
wmnnd
force-pushed
the
main
branch
2 times, most recently
from
b351172 to
dbdef3a
Compare
wmnnd
force-pushed
the
main
branch
12 times, most recently
from
df49604 to
1caf656
Compare
wmnnd
force-pushed
the
main
branch
2 times, most recently
from
9daf09a to
4ed1a52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
Mailings.try_credentials/1which will attempt to send a test email with the provided sender credentials.It’s currently integrated into the UI so that users receive a warning when sending the email failed but the config is still saved:
