Fix compiler warnings

Author: wmnnd

extra/keila_cloud_web/controllers/cloud_account_controller.ex

@@ -4,7 +4,6 @@ Keila.if_cloud do
   defmodule KeilaWeb.CloudAccountController do
     use KeilaWeb, :controller
     import Phoenix.LiveView.Controller
-    import Ecto.Changeset
 
     def onboarding(conn, _) do
       live_render(conn, KeilaWeb.CloudAccountOnboardingLive,

extra/keila_cloud_web/controllers/cloud_account_onboarding_live.ex

@@ -3,7 +3,6 @@ require Keila
 Keila.if_cloud do
   defmodule KeilaWeb.CloudAccountOnboardingLive do
     use KeilaWeb, :live_view
-    import Ecto.Changeset
 
     alias KeilaCloud.Accounts.Account.ContactData
     alias KeilaCloud.Accounts.Account.OnboardingReviewData
@@ -18,8 +17,8 @@ Keila.if_cloud do
 
       {:ok,
        socket
-       |> assign(:current_user, session["current_user"])
-       |> assign(:current_account, session["current_account"])
+       |> assign(:current_user, current_user)
+       |> assign(:current_account, current_account)
        |> assign(:countries, countries)
        |> assign(:step, :user_name)
        |> put_user_changeset()
@@ -53,8 +52,7 @@ Keila.if_cloud do
 
     defp put_onboarding_review_data_changeset(socket, params \\ %{}) do
       onboarding_review_data =
-        socket.assigns.current_account.onboarding_review_data ||
-          %KeilaCloud.Accounts.Account.OnboardingReviewData{}
+        socket.assigns.current_account.onboarding_review_data || %OnboardingReviewData{}
 
       assign(
         socket,

extra/keila_cloud_web/controllers/cloud_admin_controller.ex

@@ -3,7 +3,6 @@ require Keila
 Keila.if_cloud do
   defmodule KeilaWeb.CloudAdminController do
     use KeilaWeb, :controller
-    import Phoenix.LiveView.Controller
 
     plug :authorize
 

extra/keila_cloud_web/views/cloud_account_view.ex

@@ -7,7 +7,6 @@ Keila.if_cloud do
       namespace: KeilaWeb
 
     use Phoenix.HTML
-    import Phoenix.View
     import Phoenix.LiveView.Helpers
     import KeilaWeb.Gettext
     import KeilaWeb.ErrorHelpers
@@ -46,7 +45,7 @@ Keila.if_cloud do
 
     defp format_to_field_groups(format, field_groups \\ [[]])
 
-    @known_fields ~w[given_name additional_name family_name organization_name postal_code sorting_code dependent_locality locality administrative_area country address_line_1 sorting_code address_line_2 address_line_3]
+    @known_fields ~w[given_name additional_name family_name organization_name postal_code sorting_code dependent_locality locality administrative_area country address_line_1 address_line_2 address_line_3]
 
     for field <- @known_fields do
       @field field

extra/keila_cloud_web/views/cloud_admin_view.ex

@@ -7,11 +7,9 @@ Keila.if_cloud do
       namespace: KeilaWeb
 
     use Phoenix.HTML
-    import Phoenix.View
     import Phoenix.LiveView.Helpers
 
     import KeilaWeb.Gettext
-    import KeilaWeb.ErrorHelpers
     alias KeilaWeb.Router.Helpers, as: Routes
   end
 end

lib/keila/mailings/sender_adapters.ex

@@ -26,23 +26,23 @@ defmodule Keila.Mailings.SenderAdapters do
   """
   @spec adapter_names() :: list(String.t())
   def adapter_names do
-    Enum.map(adapters(), fn a -> a.name end)
+    Enum.map(adapters(), fn adapter -> adapter.name() end)
   end
 
   @doc """
   Returns the names of all configured shared sender adapters.
   """
   @spec shared_adapter_names() :: list(String.t())
   def shared_adapter_names do
-    Enum.map(shared_adapters(), fn a -> a.name end)
+    Enum.map(shared_adapters(), fn adapter -> adapter.name() end)
   end
 
   @doc """
   Returns the configured sender adapter or shared sender adapter with the given `name`
   """
   @spec get_adapter(String.t()) :: Keila.Mailings.SenderAdapters.Adapter.t()
   def get_adapter(name) do
-    Enum.find(adapters() ++ shared_adapters(), fn a -> a.name == name end)
+    Enum.find(adapters() ++ shared_adapters(), fn adapter -> adapter.name() == name end)
   end
 
   @doc """

lib/keila_web/live/segment_edit_live.ex

@@ -296,13 +296,13 @@ defmodule KeilaWeb.SegmentEditLive do
   defp filter_condition_to_form_data("string", _field, %{"$like" => value}) do
     cond do
       String.starts_with?(value, "%") && String.ends_with?(value, "%") ->
-        %{"value" => String.slice(value, 1..-2), "widget" => "includes"}
+        %{"value" => String.slice(value, 1..-2//-1), "widget" => "includes"}
 
       String.starts_with?(value, "%") ->
-        %{"value" => String.slice(value, 1..-1), "widget" => "ends_with"}
+        %{"value" => String.slice(value, 1..-1//-1), "widget" => "ends_with"}
 
       String.ends_with?(value, "%") ->
-        %{"value" => String.slice(value, 0..-2), "widget" => "starts_with"}
+        %{"value" => String.slice(value, 0..-2//-1), "widget" => "starts_with"}
     end
   end