Skip to content

FFI dev shell follow-ups #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benalleng merged 2 commits into from
May 29, 2026
Merged

FFI dev shell follow-ups #1587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d06c7b6
Update C# dev shell docs
chavic May 28, 2026
fe14350
Guard JS rustup target setup
chavic May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions payjoin-ffi/csharp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ Welcome to the C# language bindings for the [Payjoin Dev Kit](https://payjoindev

Follow these steps to clone the repository and run the tests.

With nix, the default development shell provides the Rust toolchain, .NET 10 SDK,
and .NET 8 runtime:
With nix, the C# development shell provides the Rust toolchain and .NET 10 SDK:

```shell
nix develop -c bash payjoin-ffi/csharp/contrib/test.sh
nix develop .#csharp -c bash payjoin-ffi/csharp/contrib/test.sh
```

```shell
Expand Down Expand Up @@ -55,7 +54,7 @@ dotnet test

## Requirements

- .NET 8.0 or higher
- .NET 10.0 or higher
- Rust toolchain (MSRV: 1.85.0 for this repository)
- Cargo will fetch the C# generator from `chavic/uniffi-bindgen-cs` at commit `878a3d269eacce64beadcd336ade0b7c8da09824` (pinned in `payjoin-ffi/Cargo.toml`)

Expand Down
7 changes: 6 additions & 1 deletion payjoin-ffi/javascript/scripts/generate_bindings.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ cd node_modules/uniffi-bindgen-react-native
cargo add home@=0.5.11 --package uniffi-bindgen-react-native
cd ../..

rustup target add wasm32-unknown-unknown
# rustup target add is a no-op against a nix-provided toolchain
Copy link
Copy Markdown
Collaborator Author

@chavic chavic May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied this pattern from python/generate_bindings.sh

# (no rustup home, targets baked into the nix derivation instead).
if command -v rustup >/dev/null 2>&1 &&
rustup show active-toolchain >/dev/null 2>&1; then
rustup target add wasm32-unknown-unknown
fi

npm run build
npm run build:test-utils
Expand Down
Loading