FFI dev shell follow-ups#1587
Merged
benalleng merged 2 commits intoMay 29, 2026
Merged
Conversation
Collaborator
Coverage Report for CI Build 26589670103Coverage remained the same at 85.31%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
chavic
commented
May 28, 2026
| cd ../.. | ||
|
|
||
| rustup target add wasm32-unknown-unknown | ||
| # rustup target add is a no-op against a nix-provided toolchain |
Collaborator
Author
There was a problem hiding this comment.
copied this pattern from python/generate_bindings.sh
benalleng
reviewed
May 28, 2026
Collaborator
benalleng
left a comment
benalleng
left a comment
There was a problem hiding this comment.
CACK nice catches, glad you followed up with these. anything notable keeping this in draft?
benalleng
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the C# README to point users at the dedicated .#csharp Nix dev shell and aligns the documented .NET requirement with the current net10.0 test target.
It also updates the JavaScript binding generation script to guard rustup target add wasm32-unknown-unknown, matching the Python script's behavior so Nix-provided toolchains do not require a host rustup setup.