-
Notifications
You must be signed in to change notification settings - Fork 5
Setup make_request as a generic server fn #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
4e14c81 to
42c60b5
Compare
08f4697 to
b096bca
Compare
a97db2c to
8cd9b25
Compare
8cd9b25 to
39dfc9e
Compare
|
So far seems fine. Need a reproducible example to test against @argha-dot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the API routing functions to use JSON-specific endpoint mounting, aligning route registration with a new generic server function design. Key changes include replacing mount_auth_endpoint/mount_endpoint with mount_auth_json_endpoint/mount_json_endpoint across multiple modules, adjusting tuple destructuring in start_deployment.rs, and adding the server_fn dependency in Cargo.toml.
Reviewed Changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/src/routes/api.patr.cloud/workspace/secret/mod.rs | Updated secret endpoints to use mount_auth_json_endpoint. |
| api/src/routes/api.patr.cloud/workspace/runner/mod.rs | Updated runner endpoints to use mount_auth_json_endpoint. |
| api/src/routes/api.patr.cloud/workspace/rbac/user/mod.rs | Updated user RBAC endpoints for JSON. |
| api/src/routes/api.patr.cloud/workspace/rbac/role/mod.rs | Updated role endpoints to use JSON-specific mounting. |
| api/src/routes/api.patr.cloud/workspace/rbac/permission/mod.rs | Updated permission endpoints accordingly. |
| api/src/routes/api.patr.cloud/workspace/mod.rs | Updated workspace endpoints to use mount_auth_json_endpoint. |
| api/src/routes/api.patr.cloud/workspace/managed_url/mod.rs | Updated managed URL endpoints to leverage JSON endpoints. |
| api/src/routes/api.patr.cloud/workspace/domain/mod.rs | Replaced mount_endpoint and mount_auth_endpoint with JSON versions. |
| api/src/routes/api.patr.cloud/workspace/deployment/start_deployment.rs | Changed tuple destructuring to ignore unused values. |
| api/src/routes/api.patr.cloud/workspace/deployment/mod.rs | Updated deployment endpoints to use JSON-specific mounts. |
| api/src/routes/api.patr.cloud/workspace/deployment/deploy_history/mod.rs | Updated deploy history endpoints for JSON. |
| api/src/routes/api.patr.cloud/workspace/database/mod.rs | Updated database endpoints to use JSON mounts. |
| api/src/routes/api.patr.cloud/user/web_logins/mod.rs | Updated web logins endpoints for JSON. |
| api/src/routes/api.patr.cloud/user/recovery_options/mod.rs | Updated recovery options endpoints for JSON. |
| api/src/routes/api.patr.cloud/user/mod.rs | Updated user endpoints to use JSON-specific mounts. |
| api/src/routes/api.patr.cloud/user/mfa/mod.rs | Updated MFA endpoints to use mount_auth_json_endpoint. |
| api/src/routes/api.patr.cloud/user/api_token/mod.rs | Updated API token endpoints to leverage JSON versions. |
| api/src/routes/api.patr.cloud/auth/oauth/mod.rs | Updated OAuth endpoints to use JSON endpoint mounting. |
| api/src/routes/api.patr.cloud/auth/mod.rs | Updated authorization endpoints to use JSON-specific mounts. |
| Cargo.toml | Added server_fn dependency to support generic server function calls. |
Comments suppressed due to low confidence (1)
api/src/routes/api.patr.cloud/workspace/deployment/start_deployment.rs:37
- Ensure that omitting 'image_tag' and 'region' from the tuple assignment is intentional and that these values are no longer required; if they are needed later in the code, adjust their usage accordingly.
let (registry, ..) = query!(
fd431c7 to
4415aba
Compare
…pendencies; update response handling to use BrowserResponse
141d780 to
c3da2e7
Compare
… across routes. Leptos' internal stuff broke something. Need to figure this out now
ca94b74 to
00d5f4a
Compare
No description provided.