Refactor API token update logic and replace make_api_call with make_request

Author: rakshith-ravi

frontend/common/src/utils/ext_traits.rs

@@ -46,23 +46,3 @@ where
 		Signal::derive(move || f(self.get()))
 	}
 }
-
-/// A trait to extend the [`String`] type with some useful methods that are not
-/// available in the standard library. This is useful for adding utility methods
-/// to the [`String`] type without polluting the global namespace.
-pub trait StringExt {
-	/// Wraps the [`String`] into an option depending on whether it's empty
-	/// Returns [`None`] if string is empty otherwise returns the string wrapped
-	/// in a [`Some()`]
-	fn some_if_not_empty(self) -> Option<String>;
-}
-
-impl StringExt for String {
-	fn some_if_not_empty(self) -> Option<String> {
-		if self.is_empty() {
-			None
-		} else {
-			Some(self)
-		}
-	}
-}

old-frontend/src/pages/auth/login.rs

@@ -18,7 +18,7 @@ pub async fn login(
 	let LoginResponse {
 		access_token,
 		refresh_token,
-	} = make_api_call::<LoginRequest>(
+	} = make_request::<LoginRequest>(
 		ApiRequest::builder()
 			.path(LoginPath)
 			.query(())
@@ -35,7 +35,7 @@ pub async fn login(
 	.await?
 	.body;
 
-	let workspaces = make_api_call::<ListUserWorkspacesRequest>(
+	let workspaces = make_request::<ListUserWorkspacesRequest>(
 		ApiRequest::builder()
 			.path(ListUserWorkspacesPath)
 			.query(())

old-frontend/src/pages/auth/sign_up.rs

@@ -13,7 +13,7 @@ pub async fn sign_up(
 	username: String,
 	password: String,
 ) -> Result<(), ServerFnError<ErrorType>> {
-	make_api_call::<CreateAccountRequest>(
+	make_request::<CreateAccountRequest>(
 		ApiRequest::builder()
 			.path(CreateAccountPath)
 			.query(())
@@ -80,7 +80,7 @@ pub fn SignUpForm(
 	// 		}
 
 	// 		let Ok(IsEmailValidResponse { available }) =
-	// make_api_call::<IsEmailValidRequest>( 			ApiRequest::builder()
+	// make_request::<IsEmailValidRequest>( 			ApiRequest::builder()
 	// 				.path(IsEmailValidPath)
 	// 				.query(IsEmailValidQuery { email })
 	// 				.headers(IsEmailValidRequestHeaders {
@@ -121,7 +121,7 @@ pub fn SignUpForm(
 	// 		}
 
 	// 		let Ok(IsUsernameValidResponse { available }) =
-	// 			make_api_call::<IsUsernameValidRequest>(
+	// 			make_request::<IsUsernameValidRequest>(
 	// 				ApiRequest::builder()
 	// 					.path(IsUsernameValidPath)
 	// 					.query(IsUsernameValidQuery { username })