-
Notifications
You must be signed in to change notification settings - Fork 9
Add lowering from AST to logical plan for graph MATCH #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Conformance comparison report
Number passing in both: 5603 Number failing in both: 826 Number passing in Base (3d4e27b) but now fail: 0 Number failing in Base (3d4e27b) but now pass: 0 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-plan-gpml #551 +/- ##
==================================================
+ Coverage 81.56% 81.93% +0.36%
==================================================
Files 107 108 +1
Lines 22487 22723 +236
Branches 22487 22723 +236
==================================================
+ Hits 18342 18618 +276
+ Misses 3632 3567 -65
- Partials 513 538 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
332942e
to
e0a6101
Compare
#[allow(dead_code)] // TODO with sub-graphs in graph MATCH | ||
Pattern(Vec<MatchElement>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this TODO still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
This PR:
experimental
conformance tests which include the GPML testspub
modules.Some of the graph conformance tests are still failing; These are largely tests that specify only an edge and have implicit start and end nodes (e.g.,
( graph MATCH -> )
).The current grammar cannot parse such a construction. I intend to tackle this in follow-up work, perhaps including modernizing the grammar to follow SQL '23.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.