Skip to content

Add lowering from AST to logical plan for graph MATCH #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Mar 25, 2025

This PR:


Some of the graph conformance tests are still failing; These are largely tests that specify only an edge and have implicit start and end nodes (e.g., ( graph MATCH -> )).

The current grammar cannot parse such a construction. I intend to tackle this in follow-up work, perhaps including modernizing the grammar to follow SQL '23.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Mar 25, 2025

Conformance comparison report

Base (3d4e27b) 3d4e27b +/-
% Passing 87.15% 86.85% -0.31%
✅ Passing 5603 5731 128
❌ Failing 826 868 42
🔶 Ignored 0 0 0
Total Tests 6429 6599 170

Number passing in both: 5603

Number failing in both: 826

Number passing in Base (3d4e27b) but now fail: 0

Number failing in Base (3d4e27b) but now pass: 0

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 83.94649% with 48 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (2bf9bbf) to head (e0a6101).
Report is 1 commits behind head on feat-plan-gpml.

Files with missing lines Patch % Lines
partiql-logical-planner/src/graph.rs 80.09% 34 Missing and 9 partials ⚠️
partiql-logical-planner/src/lower.rs 75.00% 3 Missing and 1 partial ⚠️
partiql-eval/src/plan.rs 96.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           feat-plan-gpml     #551      +/-   ##
==================================================
+ Coverage           81.56%   81.93%   +0.36%     
==================================================
  Files                 107      108       +1     
  Lines               22487    22723     +236     
  Branches            22487    22723     +236     
==================================================
+ Hits                18342    18618     +276     
+ Misses               3632     3567      -65     
- Partials              513      538      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpschorr jpschorr marked this pull request as ready for review March 26, 2025 16:22
@jpschorr jpschorr requested review from am357 and alancai98 March 26, 2025 16:22
Comment on lines +27 to +28
#[allow(dead_code)] // TODO with sub-graphs in graph MATCH
Pattern(Vec<MatchElement>),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this TODO still relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@jpschorr jpschorr merged commit 0e05d6d into feat-plan-gpml Apr 1, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants