Skip to content

Add lowering from AST to logical plan for graph MATCH #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2025

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Apr 4, 2025

Note: this is a recapitulation of #551, as that got merged to the wrong branch


This PR:


Some of the graph conformance tests are still failing; These are largely tests that specify only an edge and have implicit start and end nodes (e.g., ( graph MATCH -> )).

The current grammar cannot parse such a construction. I intend to tackle this in follow-up work, perhaps including modernizing the grammar to follow SQL '23.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested review from alancai98 and am357 and removed request for alancai98 April 4, 2025 23:07
@jpschorr jpschorr force-pushed the feat-lower-gpml-merge branch from e0a6101 to 024006d Compare April 4, 2025 23:11
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 84.10596% with 48 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (a6d8e0f) to head (12eab14).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
partiql-logical-planner/src/graph.rs 80.09% 34 Missing and 9 partials ⚠️
partiql-logical-planner/src/lower.rs 75.00% 3 Missing and 1 partial ⚠️
partiql-eval/src/plan.rs 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   81.56%   81.93%   +0.36%     
==========================================
  Files         107      108       +1     
  Lines       22487    22721     +234     
  Branches    22487    22721     +234     
==========================================
+ Hits        18342    18616     +274     
+ Misses       3632     3567      -65     
- Partials      513      538      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Apr 4, 2025

Conformance comparison report

Base (a6d8e0f) 0291c1d +/-
% Passing 87.15% 86.85% -0.31%
✅ Passing 5603 5731 128
❌ Failing 826 868 42
🔶 Ignored 0 0 0
Total Tests 6429 6599 170

Number passing in both: 5603

Number failing in both: 826

Number passing in Base (a6d8e0f) but now fail: 0

Number failing in Base (a6d8e0f) but now pass: 0

@jpschorr jpschorr merged commit 9baff4b into main Apr 5, 2025
19 checks passed
@jpschorr jpschorr deleted the feat-lower-gpml-merge branch April 5, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants