Skip to content

Passes the spec, but I can still see some potential issues #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gwadej wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Passes the spec, but I can still see some potential issues #17

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16e43f2
Passes the spec, but I can still see some potential issues
Oct 1, 2015
1d0e51d
Simplify logic
Oct 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
def word_in_string?(word, string)
# implement with your code here
string.match( /(?:\b|_)#{word}(?:\b|_)/ ).nil? ? :no : :yes
Copy link
Member

@mikegee mikegee Oct 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work the same if you drop the .nil? and switch the yes/no?

Copy link
Author

@gwadej gwadej Oct 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a problem earlier that the nil? fixed.
It apparently doesn't apply now.

Removed.

end