Passes the spec, but I can still see some potential issues #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 what are the potential issues? |
Author
|
@jaybobo That's all I can think of off the top of my head. If I took a little time to go into tester mode I might be able to come up with some more. Like no check for empty string or nil. |
Author
|
As suggested by Jay: Please review @mikegee |
parser.rb
Outdated
Member
There was a problem hiding this comment.
Does it work the same if you drop the .nil? and switch the yes/no?
Author
There was a problem hiding this comment.
I had a problem earlier that the nil? fixed.
It apparently doesn't apply now.
Removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got this one finished to spec. @chivygab, @jaybobo Read for a code review.