-
Notifications
You must be signed in to change notification settings - Fork 36
complete #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewlee07
wants to merge
1
commit into
paircolumbus:master
Choose a base branch
from
matthewlee07:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
complete #49
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| gem 'rspec' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| GEM | ||
| specs: | ||
| diff-lcs (1.3) | ||
| rspec (3.8.0) | ||
| rspec-core (~> 3.8.0) | ||
| rspec-expectations (~> 3.8.0) | ||
| rspec-mocks (~> 3.8.0) | ||
| rspec-core (3.8.0) | ||
| rspec-support (~> 3.8.0) | ||
| rspec-expectations (3.8.2) | ||
| diff-lcs (>= 1.2.0, < 2.0) | ||
| rspec-support (~> 3.8.0) | ||
| rspec-mocks (3.8.0) | ||
| diff-lcs (>= 1.2.0, < 2.0) | ||
| rspec-support (~> 3.8.0) | ||
| rspec-support (3.8.0) | ||
|
|
||
| PLATFORMS | ||
| ruby | ||
|
|
||
| DEPENDENCIES | ||
| rspec | ||
|
|
||
| BUNDLED WITH | ||
| 2.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| class Count_Words | ||
| attr_reader :book | ||
|
|
||
| def initialize | ||
| @book = Hash.new(0) | ||
| end | ||
|
|
||
| def count_words(input_string) | ||
| input_string.scan(/\w+/).each do |word| | ||
| @book[word.downcase]+=1 | ||
| end | ||
| end | ||
|
|
||
| def order_book_by_count | ||
| @book = @book.sort_by{|k,v|-v} | ||
| end | ||
|
|
||
| def render_book | ||
| @book.map do |k,v| | ||
| puts "#{k}: #{v}" | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| require_relative 'lib/count_words' | ||
|
|
||
| counter = Count_Words.new | ||
|
|
||
| File.open('speech.txt','r') do |file| | ||
| file.each do |line| | ||
| counter.count_words(line) | ||
| end | ||
| counter.order_book_by_count | ||
| counter.render_book | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| require 'rspec' | ||
| require_relative '../lib/count_words' | ||
|
|
||
| describe 'initializing book' do | ||
| let(:test) { Count_Words.new } | ||
|
|
||
| it 'test starts empty' do | ||
| expect(test.book).to eq({}) | ||
| end | ||
| end | ||
|
|
||
| describe 'counting a single string' do | ||
| let(:test){ Count_Words.new} | ||
|
|
||
| it 'counters have correct values' do | ||
| test.count_words('The cat is tall. The cat is much bigger than the mouse.') | ||
| expected = { | ||
| 'the' => 3, | ||
| 'cat' => 2, | ||
| 'is' => 2, | ||
| 'tall' => 1, | ||
| 'mouse' => 1, | ||
| 'bigger' => 1, | ||
| 'than' => 1, | ||
| 'much' => 1 | ||
| } | ||
| expect(test.book).to eq(expected) | ||
| end | ||
| end | ||
|
|
||
| describe 'handle garbage' do | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen this strategy before. Typically folks will give all the file content to the object and then ask for a report. Something like:
But I don't mean to imply there's anything wrong with your approach. Reading the file one line at a time is great for really big files.
If you feel like practicing more, you could try switching approaches. This is pretty awesome as-is, though. Let me know if you would like any additional guidance.