complete #49
complete #49
Conversation
| end | ||
| counter.order_book_by_count | ||
| counter.render_book | ||
| end |
There was a problem hiding this comment.
I haven't seen this strategy before. Typically folks will give all the file content to the object and then ask for a report. Something like:
corpus = File.read('speech.txt')
counter = Count_Words.new(corpus)
puts counter.wordsBut I don't mean to imply there's anything wrong with your approach. Reading the file one line at a time is great for really big files.
If you feel like practicing more, you could try switching approaches. This is pretty awesome as-is, though. Let me know if you would like any additional guidance.
|
I have my apprenticeship interview with CMM tomorrow. Do you think a solution like this would be acceptable, or is it better to go with your recommendation? And is there anything else that'd help prepare me? |
Either way is really ok. It's just important that you can justify the decision. What are the pros and cons of each approach? What kinds of future changes would be easy to handle in the code versus needing to rethink the approach? Does it need to handle multi-gigabyte inputs or streaming inputs? |
2 participants
No description provided.