-
Notifications
You must be signed in to change notification settings - Fork 43
Raise Nexus' VM memory limit to 1T #8160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
both Crucible and Propolis are trivial bumps - the only changes in each are a similar bump of Progenitor.
openapi/wicketd.json
Outdated
@@ -3582,7 +3582,7 @@ | |||
] | |||
}, | |||
"RotImageError": { | |||
"description": "RotImageError\n\n<details><summary>JSON schema</summary>\n\n```json { \"type\": \"string\", \"enum\": [ \"unchecked\", \"first_page_erased\", \"partially_programmed\", \"invalid_length\", \"header_not_programmed\", \"bootloader_too_small\", \"bad_magic\", \"header_image_size\", \"unaligned_length\", \"unsupported_type\", \"reset_vector_not_thumb2\", \"reset_vector\", \"signature\" ] } ``` </details>", | |||
"description": "`RotImageError`\n\n<details><summary>JSON schema</summary>\n\n```json { \"type\": \"string\", \"enum\": [ \"unchecked\", \"first_page_erased\", \"partially_programmed\", \"invalid_length\", \"header_not_programmed\", \"bootloader_too_small\", \"bad_magic\", \"header_image_size\", \"unaligned_length\", \"unsupported_type\", \"reset_vector_not_thumb2\", \"reset_vector\", \"signature\" ] } ``` </details>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the only change to the OpenAPI schemas is the addition of backticks around the schema name in each case. Sure, whatever! I assume that came from the dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's in #8086 too, just fallout from the Progenitor version bump. ... i was not sure why only these items were affected but it looks like this is a default description if the item doesn't have one, and everything else has doc comments.
this includes the Progenitor bump in 8086 only because Propolis is now at Progenitor 0.10.0. if you want to go sign off on 8086 though, it'll make the diff here much much more clear (and tbh the two separate piece being in two different commits makes a lot more sense to me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending testing, nice comment
fixes #7918. ish. it would be nice to not have a hardcoded limit here at all. while one might think there shouldn't be a real difference in behavior from here up to about 16 TiB VMs, reality confounds. oxidecomputer/propolis#907 is the next issue we'll run into for raising VM size limits further.
Angela has instances up to and including 1T a try with notes on #7918. it would be nice to set this as high as 1.5T, since that fits well on a Gimlet with 2T of memory, but trying that is how we found Propolis#907.