Raise Nexus' VM memory limit to 1T (#8160)

fixes #7918. ish. it would be nice to not have a hardcoded limit here at
all. while one might think there _shouldn't_ be a real difference in
behavior from here up to about 16 TiB VMs, reality confounds.
oxidecomputer/propolis#907 is the next issue
we'll run into for raising VM size limits further.

Angela has instances up to and including 1T a try with notes on #7918.
it would be nice to set this as high as 1.5T, since that fits well on a
Gimlet with 2T of memory, but trying that is how we found Propolis#907.

Author: iximeow

Cargo.lock

@@ -606,10 +606,10 @@ progenitor-client = "0.10.0"
 # NOTE: if you change the pinned revision of the `bhyve_api` and propolis
 # dependencies, you must also update the references in package-manifest.toml to
 # match the new revision.
-bhyve_api = { git = "https://github.com/oxidecomputer/propolis", rev = "71dd30f454f35c1d33cd8ea0198116f680ac1689" }
-propolis_api_types = { git = "https://github.com/oxidecomputer/propolis", rev = "71dd30f454f35c1d33cd8ea0198116f680ac1689" }
-propolis-client = { git = "https://github.com/oxidecomputer/propolis", rev = "71dd30f454f35c1d33cd8ea0198116f680ac1689" }
-propolis-mock-server = { git = "https://github.com/oxidecomputer/propolis", rev = "71dd30f454f35c1d33cd8ea0198116f680ac1689" }
+bhyve_api = { git = "https://github.com/oxidecomputer/propolis", rev = "e3988414bd68ecf806078fb898120e1194451ee9" }
+propolis_api_types = { git = "https://github.com/oxidecomputer/propolis", rev = "e3988414bd68ecf806078fb898120e1194451ee9" }
+propolis-client = { git = "https://github.com/oxidecomputer/propolis", rev = "e3988414bd68ecf806078fb898120e1194451ee9" }
+propolis-mock-server = { git = "https://github.com/oxidecomputer/propolis", rev = "e3988414bd68ecf806078fb898120e1194451ee9" }
 # NOTE: see above!
 proptest = "1.6.0"
 qorb = "0.3.1"

Cargo.toml

@@ -127,7 +127,22 @@ pub(crate) const MAX_EPHEMERAL_IPS_PER_INSTANCE: usize = 1;
 pub const MAX_VCPU_PER_INSTANCE: u16 = 64;
 
 pub const MIN_MEMORY_BYTES_PER_INSTANCE: u32 = 1 << 30; // 1 GiB
-pub const MAX_MEMORY_BYTES_PER_INSTANCE: u64 = 256 * (1 << 30); // 256 GiB
+// This is larger than total memory (let alone reservoir) on some sleds; it is
+// not to guard against overallocation, but to keep instance memory sizes in
+// ranges that we've tested. It is bounded only by the intersection of
+// large-memory hardware configurations and tested instance sizes.
+//
+// Propolis has a similar limit in MAX_PHYSMEM. There, we would like to remove
+// the limit entirely. Here, we may want to make the max size operator
+// configurable as it may have implications on migratability for racks with
+// mixed sled configurations.
+//
+// Before raising or removing this limit, testing has been valuable. See:
+// * illumos bug #17403
+// * Propolis issue #903
+// There are known issues setting this above 1028 GiB. See:
+// * Propolis issue #907
+pub const MAX_MEMORY_BYTES_PER_INSTANCE: u64 = 1024 * (1 << 30); // 1 TiB
 
 pub const MIN_DISK_SIZE_BYTES: u32 = 1 << 30; // 1 GiB
 pub const MAX_DISK_SIZE_BYTES: u64 = 1023 * (1 << 30); // 1023 GiB

nexus/src/app/mod.rs

@@ -622,10 +622,10 @@ service_name = "propolis-server"
 only_for_targets.image = "standard"
 source.type = "prebuilt"
 source.repo = "propolis"
-source.commit = "71dd30f454f35c1d33cd8ea0198116f680ac1689"
+source.commit = "e3988414bd68ecf806078fb898120e1194451ee9"
 # The SHA256 digest is automatically posted to:
 # https://buildomat.eng.oxide.computer/public/file/oxidecomputer/propolis/image/<commit>/propolis-server.sha256.txt
-source.sha256 = "e1fe40e66b92c84503613f83de2693c8446b3b05c8e5bad914299d2ab7d7fb00"
+source.sha256 = "a858fe9db8db262b402a44598e991c6298f92531421029f7728b3fdd45fe621b"
 output.type = "zone"
 
 [package.mg-ddm-gz]