Skip to content

refactor(language_server): linter runtime returns FxHashMap #11412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sysix
Copy link
Member

@Sysix Sysix commented May 31, 2025

The language server wants to map the diagnostics to the file path

Copy link
Member Author

Sysix commented May 31, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 31, 2025
Copy link

codspeed-hq bot commented May 31, 2025

CodSpeed Instrumentation Performance Report

Merging #11412 will create unknown performance changes

Comparing 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ (7268fc6) with 05-30-refactor_language_server_introduce_helper_path_to_uri_ (9f39a1d)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[RadixUIAdoptionSection.jsx] N/A 132.4 µs N/A
🆕 codegen[binder.ts] N/A 4.8 ms N/A
🆕 codegen[cal.com.tsx] N/A 38.8 ms N/A
🆕 codegen[react.development.js] N/A 2.2 ms N/A
🆕 formatter[RadixUIAdoptionSection.jsx] N/A 299.7 µs N/A
🆕 formatter[binder.ts] N/A 19.3 ms N/A
🆕 formatter[cal.com.tsx] N/A 150.4 ms N/A
🆕 formatter[react.development.js] N/A 9.5 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21 µs N/A
🆕 lexer[binder.ts] N/A 929.3 µs N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[react.development.js] N/A 383.7 µs N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[binder.ts] N/A 149.1 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 54.6 ms N/A
🆕 mangler[RadixUIAdoptionSection.jsx] N/A 14.3 µs N/A
🆕 mangler[binder.ts] N/A 800.9 µs N/A
🆕 mangler[cal.com.tsx] N/A 3.3 ms N/A
🆕 mangler[react.development.js] N/A 282 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Sysix Sysix force-pushed the 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ branch from d822b1f to 7e4b711 Compare May 31, 2025 15:08
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from d2c136c to e7f3100 Compare May 31, 2025 16:50
@Sysix Sysix force-pushed the 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ branch from 7e4b711 to e519d9e Compare May 31, 2025 16:50
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from e7f3100 to 2414ee9 Compare June 1, 2025 11:27
@Sysix Sysix force-pushed the 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ branch from e519d9e to 18dc87f Compare June 1, 2025 11:27
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from 2414ee9 to 7708d56 Compare June 2, 2025 17:29
@Sysix Sysix force-pushed the 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ branch from 18dc87f to 4c0e32f Compare June 2, 2025 17:29
@Sysix Sysix changed the base branch from 05-30-refactor_language_server_introduce_helper_path_to_uri_ to graphite-base/11412 June 2, 2025 17:39
@Sysix Sysix force-pushed the graphite-base/11412 branch from 7708d56 to 512672d Compare June 2, 2025 17:40
@Sysix Sysix force-pushed the 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ branch from 4c0e32f to 4b057c7 Compare June 2, 2025 17:40
@Sysix Sysix changed the base branch from graphite-base/11412 to 05-30-refactor_language_server_introduce_helper_path_to_uri_ June 2, 2025 17:40
@Sysix Sysix force-pushed the 05-31-refactor_language_server_linter_runtime_returns_fxhashmap_ branch from 4b057c7 to 7268fc6 Compare June 2, 2025 21:18
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from 512672d to 9f39a1d Compare June 2, 2025 21:18
@Sysix Sysix marked this pull request as ready for review June 2, 2025 21:22
@Sysix Sysix requested a review from camc314 as a code owner June 2, 2025 21:22
@Sysix Sysix closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant