Skip to content

refactor(language_server): introduce helper path_to_uri #11398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct
Choose a base branch
from

Conversation

Sysix
Copy link
Member

@Sysix Sysix commented May 30, 2025

Currently only used for the test. The plan is to convert paths back to URI when we implement workspace wide diagnostics.
The client will not send us URIs, we need to create them on our own.

The current implementation from Uri::from_file_path is broken because of the escape characters.
I see someone from tower-lsp-server wants to implement something similar:
tower-lsp-community/tower-lsp-server#46

@github-actions github-actions bot added the A-editor Area - Editor and Language Server label May 30, 2025
Copy link
Member Author

Sysix commented May 30, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 30, 2025
Copy link

codspeed-hq bot commented May 30, 2025

CodSpeed Instrumentation Performance Report

Merging #11398 will not alter performance

Comparing 05-30-refactor_language_server_introduce_helper_path_to_uri_ (9f39a1d) with 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct (bbf7107)

Summary

✅ 38 untouched benchmarks

@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from bb7ded9 to 2ce0659 Compare May 31, 2025 12:04
@Sysix Sysix force-pushed the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch from 6e330d4 to b1f8e21 Compare May 31, 2025 12:04
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch 2 times, most recently from dfdb189 to d2c136c Compare May 31, 2025 14:18
@Sysix Sysix marked this pull request as ready for review May 31, 2025 16:41
@Sysix Sysix requested a review from camc314 as a code owner May 31, 2025 16:41
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from d2c136c to e7f3100 Compare May 31, 2025 16:50
@Sysix Sysix force-pushed the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch from b1f8e21 to e60f616 Compare May 31, 2025 16:50
@Sysix Sysix marked this pull request as draft May 31, 2025 19:39
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from e7f3100 to 2414ee9 Compare June 1, 2025 11:27
@Sysix Sysix marked this pull request as ready for review June 1, 2025 11:28
@Sysix Sysix force-pushed the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch from e60f616 to 46d0ec0 Compare June 2, 2025 17:29
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from 2414ee9 to 7708d56 Compare June 2, 2025 17:29
@Sysix Sysix changed the base branch from 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct to graphite-base/11398 June 2, 2025 17:39
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from 7708d56 to 512672d Compare June 2, 2025 17:39
@Sysix Sysix force-pushed the graphite-base/11398 branch from 46d0ec0 to 208f3b4 Compare June 2, 2025 17:39
@Sysix Sysix changed the base branch from graphite-base/11398 to 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct June 2, 2025 17:40
@Sysix Sysix force-pushed the 05-30-reactor_linter_move_walk_from_oxlint_to_oxc_linter_with_own_options_struct branch from 208f3b4 to bbf7107 Compare June 2, 2025 21:18
@Sysix Sysix force-pushed the 05-30-refactor_language_server_introduce_helper_path_to_uri_ branch from 512672d to 9f39a1d Compare June 2, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant