fix: replace `undefined` with `null` in typescript eslint ast #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

hi-ogawa merged 1 commit into main from fix-ts-eslint-undefined-to-null

Mar 17, 2025

Contributor

hi-ogawa commented Mar 17, 2025 •

edited

Loading

Part of oxc-project/oxc#9705


          fix: replace ts-eslint ast undefined with null

9cb6806

hi-ogawa marked this pull request as ready for review

March 17, 2025 05:31

hi-ogawa merged commit eb5e997 into main

hi-ogawa deleted the fix-ts-eslint-undefined-to-null branch

March 17, 2025 05:35

hi-ogawa mentioned this pull request

test(ast/estree): update acorn-test262 oxc-project/oxc#9816

Merged

graphite-app bot pushed a commit to oxc-project/oxc that referenced this pull request


          test(ast/estree): update acorn-test262 (#9816)

5f2d36b

Syncing oxc-project/acorn-test262#8.

Adding back `null` causes a new mismatch due to ts-eslint has `ExpresssionStatement.directive: string | undefined` https://github.com/typescript-eslint/typescript-eslint/blob/543d36ce9aacdb75e8bf85860984704dfbf8f8ff/packages/ast-spec/src/statement/ExpressionStatement/spec.ts#L7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet