test(ast/estree): update acorn-test262#9816
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 17, 2025
Merged
Conversation
github-actions
bot
added
the
C-test
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
changed the base branch from
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
to
graphite-base/9816
hi-ogawa
changed the base branch from
graphite-base/9816
to
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
graphite-app
bot
changed the base branch from
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
to
graphite-base/9816
hi-ogawa
changed the base branch from
graphite-base/9816
to
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
graphite-app
bot
changed the base branch from
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
to
graphite-base/9816
hi-ogawa
changed the base branch from
graphite-base/9816
to
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
graphite-app
bot
changed the base branch from
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
to
graphite-base/9816
hi-ogawa
changed the base branch from
graphite-base/9816
to
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
graphite-app
bot
changed the base branch from
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
to
graphite-base/9816
hi-ogawa
force-pushed
the
03-17-test_ast_estree_update_acorn-test262
branch
from
bd6b077 to
eea59ed
Compare
hi-ogawa
force-pushed
the
graphite-base/9816
branch
from
cec8b18 to
ee970b1
Compare
hi-ogawa
changed the base branch from
graphite-base/9816
to
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
Contributor
Author
Merge activity
|
Base automatically changed from
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint
to
main
March 17, 2025 06:02
Syncing oxc-project/estree-conformance#8. Adding back `null` causes a new mismatch due to ts-eslint has `ExpresssionStatement.directive: string | undefined` https://github.com/typescript-eslint/typescript-eslint/blob/543d36ce9aacdb75e8bf85860984704dfbf8f8ff/packages/ast-spec/src/statement/ExpressionStatement/spec.ts#L7.
graphite-app
bot
force-pushed
the
03-17-test_ast_estree_update_acorn-test262
branch
from
eea59ed to
5f2d36b
Compare
This was referenced Mar 17, 2025
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing oxc-project/estree-conformance#8.
Adding back
nullcauses a new mismatch due to ts-eslint hasExpresssionStatement.directive: string | undefinedhttps://github.com/typescript-eslint/typescript-eslint/blob/543d36ce9aacdb75e8bf85860984704dfbf8f8ff/packages/ast-spec/src/statement/ExpressionStatement/spec.ts#L7.