Skip to content

Secret API v2 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 14, 2025
Merged

Secret API v2 #56

merged 15 commits into from
Oct 14, 2025

Conversation

@ldesauw
Copy link
Contributor

@ldesauw ldesauw commented Mar 27, 2025

No description provided.

@ldesauw ldesauw force-pushed the dev/ldesauw/secrets_api branch from 88d68b0 to 1fee7b8 Compare March 27, 2025 12:45
@ldesauw
Copy link
Contributor Author

ldesauw commented Mar 27, 2025 •
edited
Loading

  • Add test
  • Check UX
  • Resolve TODO in code
  • Implement functions
    • List secret
    • List secret/path/version
    • Post secret/path/version
    • Get secret/path/version/version
    • Put secret/path/version/version
  • Factorize code
  • Find comfortable way to display the List of secrets and versions

@ldesauw ldesauw force-pushed the dev/ldesauw/secrets_api branch 12 times, most recently from 4e1012c to 06a0466 Compare March 28, 2025 15:03
BenHaramboure
BenHaramboure reviewed Mar 28, 2025
View reviewed changes
BenHaramboure
BenHaramboure reviewed Mar 28, 2025
View reviewed changes
BenHaramboure
BenHaramboure reviewed Mar 28, 2025
View reviewed changes
BenHaramboure
BenHaramboure reviewed Mar 28, 2025
View reviewed changes
@BenHaramboure
Copy link

BenHaramboure commented Mar 28, 2025 •
edited
Loading

it might be interesting to have info block in tests if that makes sense @ldesauw
info: response time is {{.result.timeseconds}} and response code is {{.result.code}} result is {{.result}}

@ldesauw ldesauw force-pushed the dev/ldesauw/secrets_api branch from 1964c50 to cb86a0d Compare March 28, 2025 15:59
@ldesauw ldesauw force-pushed the dev/ldesauw/secrets_api branch 7 times, most recently from 0b0f384 to 468c92e Compare April 8, 2025 13:01
BenHaramboure
BenHaramboure reviewed Apr 8, 2025
View reviewed changes
BenHaramboure
BenHaramboure reviewed Apr 8, 2025
View reviewed changes
BenHaramboure
BenHaramboure reviewed Apr 8, 2025
View reviewed changes
@ldesauw ldesauw force-pushed the dev/ldesauw/secrets_api branch from 0eb2771 to e2e9bc5 Compare September 9, 2025 16:02
@gbahezre gbahezre force-pushed the dev/ldesauw/secrets_api branch 7 times, most recently from 1bd898b to c3b0779 Compare September 18, 2025 13:19
@gbahezre gbahezre force-pushed the dev/ldesauw/secrets_api branch 4 times, most recently from 12cbae9 to b057b0f Compare October 14, 2025 16:18
@gbahezre gbahezre force-pushed the dev/ldesauw/secrets_api branch from b057b0f to 0e5ca81 Compare October 14, 2025 16:27
@gbahezre gbahezre merged commit 5ab29be into main Oct 14, 2025
9 checks passed
@gbahezre gbahezre deleted the dev/ldesauw/secrets_api branch October 14, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenHaramboure BenHaramboure BenHaramboure left review comments

@inessebz inessebz inessebz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ldesauw @BenHaramboure @inessebz @gbahezre