feat(secretv2): add secret v2 implementation

Author: ldesauw

cmd/okms/main.go

@@ -8,6 +8,8 @@ import (
 	"github.com/ovh/okms-cli/cmd/okms/configure"
 	"github.com/ovh/okms-cli/cmd/okms/keys"
 	"github.com/ovh/okms-cli/cmd/okms/kmip"
+	"github.com/ovh/okms-cli/cmd/okms/secrets"
+	secretsv2 "github.com/ovh/okms-cli/cmd/okms/secretsV2"
 
 	"github.com/ovh/okms-cli/cmd/okms/x509"
 	"github.com/ovh/okms-cli/common/commands"
@@ -36,7 +38,8 @@ func createRootCommand() *cobra.Command {
 	command.AddCommand(
 		// rnd.CreateCommand(nil),
 		keys.CreateCommand(nil),
-		// secrets.CreateCommand(nil),
+		secrets.CreateCommand(nil),
+		secretsv2.CreateCommand(nil),
 		x509.CreateX509Command(nil),
 		kmip.NewCommand(nil),
 		configure.CreateCommand(),

cmd/okms/secrets/root.go

@@ -7,8 +7,8 @@ import (
 
 func CreateCommand(cust common.CustomizeFunc) *cobra.Command {
 	var kvCmd = &cobra.Command{
-		Use:     "secrets",
-		Aliases: []string{"kv", "secret"},
+		Use:     "vault",
+		Aliases: []string{"kv"},
 		Short:   "This command has subcommands for interacting with KMS's key-value store.",
 	}
 

cmd/okms/secretsV2/config.go

@@ -0,0 +1,93 @@
+package secretsv2
+
+import (
+	"fmt"
+	"os"
+
+	"github.com/olekukonko/tablewriter"
+	"github.com/ovh/okms-cli/cmd/okms/common"
+	"github.com/ovh/okms-cli/common/flagsmgmt"
+	"github.com/ovh/okms-cli/common/output"
+	"github.com/ovh/okms-cli/common/utils"
+	"github.com/ovh/okms-cli/common/utils/exit"
+	"github.com/ovh/okms-sdk-go/types"
+	"github.com/spf13/cobra"
+)
+
+func secretConfigCommand() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "config",
+		Short: "Manages secret engine configuration",
+	}
+
+	cmd.AddCommand(
+		secretGetConfigCommand(),
+		secretUpdateConfigCommand(),
+	)
+	return cmd
+}
+
+func secretGetConfigCommand() *cobra.Command {
+	return &cobra.Command{
+		Use:   "get",
+		Short: "Retrieve secrets configuration",
+		Args:  cobra.NoArgs,
+		Run: func(cmd *cobra.Command, args []string) {
+			resp := exit.OnErr2(common.Client().GetSecretConfigV2(cmd.Context()))
+			if cmd.Flag("output").Value.String() == string(flagsmgmt.JSON_OUTPUT_FORMAT) {
+				output.JsonPrint(resp)
+			} else {
+				table := tablewriter.NewWriter(os.Stdout)
+				table.AppendBulk([][]string{
+					{"cas", fmt.Sprintf("%t", utils.DerefOrDefault(resp.CasRequired))},
+					{"Deactivate version after", utils.DerefOrDefault(resp.DeactivateVersionAfter)},
+					{"Max. number of versions", fmt.Sprintf("%d", utils.DerefOrDefault(resp.MaxVersions))},
+				})
+				table.Render()
+			}
+		},
+	}
+}
+
+func secretUpdateConfigCommand() *cobra.Command {
+	var (
+		casRequired        bool
+		maxVersions        uint32
+		deleteVersionAfter string
+	)
+
+	cmd := &cobra.Command{
+		Use:   "update",
+		Short: "Update secrets configuration",
+		Args:  cobra.MinimumNArgs(1),
+		Run: func(cmd *cobra.Command, args []string) {
+			var c *bool
+			if cmd.Flag("cas-required").Changed {
+				c = &casRequired
+			}
+
+			var d *string
+			if cmd.Flag("delete-after").Changed {
+				d = &deleteVersionAfter
+			}
+
+			var m *uint32
+			if cmd.Flag("max-versions").Changed {
+				m = &maxVersions
+			}
+
+			body := types.PostConfigRequest{
+				CasRequired:        c,
+				DeleteVersionAfter: d,
+				MaxVersions:        m,
+			}
+
+			exit.OnErr(common.Client().PostSecretConfig(cmd.Context(), body))
+		},
+	}
+
+	cmd.Flags().BoolVar(&casRequired, "cas-required", false, "If true all keys will require the cas parameter to be set on all write requests.")
+	cmd.Flags().Uint32Var(&maxVersions, "max-versions", 0, "The number of versions to keep per key. This value applies to all keys, but a key's metadata setting can overwrite this value. Once a key has more than the configured allowed versions, the oldest version will be permanently deleted. ")
+	cmd.Flags().StringVar(&deleteVersionAfter, "delete-after", "0s", "If set, specifies the length of time before a version is deleted.\nDate format, see: https://developer.hashicorp.com/vault/docs/concepts/duration-format")
+	return cmd
+}

cmd/okms/secretsV2/root.go

@@ -0,0 +1,27 @@
+package secretsv2
+
+import (
+	"github.com/ovh/okms-cli/cmd/okms/common"
+	"github.com/spf13/cobra"
+)
+
+func CreateCommand(cust common.CustomizeFunc) *cobra.Command {
+	var kvCmd = &cobra.Command{
+		Use:     "secrets",
+		Aliases: []string{"kv2", "secret"}, // TODO discuss keywords to use for better UX
+		Short:   "This command has subcommands for interacting with KMS's key-value store.",
+	}
+
+	common.SetupRestApiFlags(kvCmd, cust)
+
+	kvCmd.AddCommand(
+		secretConfigCommand(),
+		secretListCmd(),
+		secretPostCmd(),
+		secretGetCmd(),
+		secretPutCmd(),
+		secretDeleteCmd(),
+	)
+
+	return kvCmd
+}