Skip to content

#270: Table of Contents Dropdown Implementation + Dropdown styling cleanup #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

SaqAsh
Copy link

@SaqAsh SaqAsh commented Jun 5, 2025

Summary

Implemented TableOfContentDropdown to wrap the existing Dropdown, open the matching accordion, and update the URL hash for automatic scrolling to the selected schema. Fixed existing styling issues with Dropdown

Issues

Description of Changes

UI

  • Added a new component TableOfContentsDropdown which lists all schemas and handles selection.
    • Wraps the existing Dropdown, maps schemas to menu items, and on selection calls onAccordionToggle and sets window.location.hash so the matching accordion opens and the page scrolls to that schema’s table.
    • Included the List icon from theme/icons, following existing conventions, and passed it as the leftIcon prop.

Readiness Checklist

  • Self Review
    • I have performed a self review of code
    • I have run the application locally and manually tested the feature
    • I have checked all updates to correct typos and misspellings
  • Formatting
    • Code follows the project style guide
    • Autmated code formatters (ie. Prettier) have been run
  • Local Testing
    • Successfully built all packages locally
    • Successfully ran all test suites, all unit and integration tests pass
  • Updated Tests
    • Unit and integration tests have been added that describe the bug that was fixed or the features that were added
  • Documentation
    • All new environment variables added to .env.schema file and documented in the README
    • All changes to server HTTP endpoints have open-api documentation
    • All new functions exported from their module have TSDoc comment documentation

@SaqAsh SaqAsh requested a review from joneubank June 10, 2025 20:05
@SaqAsh SaqAsh linked an issue Jun 10, 2025 that may be closed by this pull request
3 tasks
@SaqAsh SaqAsh requested a review from ciaranschutte June 24, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2A. Table of Contents Dropdown
3 participants