Add GAP distro tests

[lgoettgens]

Resolves #1065.

This is dependent on #1066 and thus includes it.

I've used the ugly hack from oscar-system/GAP_pkg#15 in GAP.Packages.test to avoid GAP packages exiting the process after running their tests. This function could be moved to a package extension on Test once the minimum required julia version is bumped to 1.8.

[lgoettgens]

Suggested change

pull_request:

IMO this shouldn't run on every commit in every PR, as it produces >150 jobs. But I have kept it here for now such that in this PR, we can already see it running.

[fingolfin]

There are >150 jobs but apparently they take less than 15 minutes to run? So perhaps we keep them on for now and see what happens?

[lgoettgens]

Fine with me

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 75.28%. Comparing base (99ddda8) to head (29c4f28).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/packages.jl	0.00%	28 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
- Coverage   75.73%   75.28%   -0.46%     
==========================================
  Files          55       55              
  Lines        4641     4669      +28     
==========================================
  Hits         3515     3515              
- Misses       1126     1154      +28     

Files with missing lines	Coverage Δ
src/packages.jl	38.67% <0.00%> (-7.08%)	⬇️

[fingolfin]

Thank you for this @lgoettgens. Could you please rebase it? I'll try to have a closer in the coming week(s)

[lgoettgens]

The help package still has some failures. Could you have a look at it?

[fingolfin]

Hmm, there also was a segfault in the atlasrep test suite (looks GC related :-/)

And another in guava which looks like maybe an encoding issue (?) but which I also can't reproduce locally

########> Diff in GAPROOT/pkg/GAP_pkg_guava/guava3.19/tst/guava.tst:649
# Input is:
p := CodeIsomorphism( C1, C2 );
# Expected output:
(2,13,7,10,8,3,5,4,14)(12,15)
# But found:
Syntax error: expression expected in /tmp/gaptempfile.5zTo2m:1
GUAVA_TEMP_VAR := � &
                  ^
Syntax error: ; expected in /tmp/gaptempfile.5zTo2m:3
false
########

In order to move things along, how about we disable those for now and merge this, then file issues about these failures and then can investigate these later.

[lgoettgens]

After re-running it is only help failing. I'll go ahead disabling this and anything that randomly fails in the next few CI runs.

[lgoettgens]

All distro tests are green now. The one failure is #1111.

[fingolfin]

See also issue #1105 (@ThomasBreuer that's another case where a package needs/wants a GAP executable)