Skip to content

Version 0.12.1 - #1070

Merged
fingolfin merged 1 commit into
masterfrom
mh/CHANGES
Dec 9, 2024
Merged

Version 0.12.1#1070
fingolfin merged 1 commit into
masterfrom
mh/CHANGES

Conversation

@fingolfin

Copy link
Copy Markdown
Member

No description provided.

@fingolfin fingolfin changed the title Set version to 0.12.1-DEV, update CHANGES.md Version 0.12.1 Dec 7, 2024
@fingolfin

Copy link
Copy Markdown
Member Author

@ThomasBreuer @lgoettgens I'd like to make one more GAP.jl release on the 0.12.x track with the changes that we accumulated before working on the upgrade to 0.13.0 with GAP 4.14.0 in it (see also PR #1069)

@codecov

codecov Bot commented Dec 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.61%. Comparing base (ec2eb03) to head (5676371).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1070   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          55       55           
  Lines        4582     4582           
=======================================
  Hits         3419     3419           
  Misses       1163     1163           
Files with missing lines Coverage Δ
gap/systemfile.g 94.44% <100.00%> (ø)
pkg/JuliaExperimental/PackageInfo.g 100.00% <100.00%> (ø)
pkg/JuliaInterface/PackageInfo.g 90.26% <100.00%> (ø)

@lgoettgens

Copy link
Copy Markdown
Member

I am not quite sure currently if #1067 breaks the new function introduced in #1066. But this is of course no blocker for anything, but I wouldn't include in any future 0.12.2 release. (after the 0.13.0 bump everything is fine again)

@fingolfin

Copy link
Copy Markdown
Member Author

@lgoettgens thanks. Just for clarification: are you saying including #1066 in 0.12.1 is fine, but #1067 should be delayed until 0.13.0?

@lgoettgens

Copy link
Copy Markdown
Member

Yes exactly. #1067 needs to be either in the same release as #1066 (aka 0.12.1) or a breaking release apart (aka 0.13.0). It should not be put in a later patch release (aka 0.12.2).

I can probably say a bit more once I am back at my computer and rebased #1067.

@lgoettgens

Copy link
Copy Markdown
Member

Now that #1067 is rebased, we can see that it (in its current form) does not touch GAP.Packages.build at all. So you can ignore everything that I wrote here about #1066 and #1067.

@fingolfin

Copy link
Copy Markdown
Member Author

@ThomasBreuer any objections to this PR?

@fingolfin fingolfin closed this Dec 9, 2024
@fingolfin fingolfin reopened this Dec 9, 2024
Comment thread CHANGES.md
Comment thread CHANGES.md Outdated
Comment thread pkg/JuliaExperimental/PackageInfo.g Outdated
Comment thread pkg/JuliaInterface/PackageInfo.g Outdated

@ThomasBreuer ThomasBreuer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@fingolfin
fingolfin merged commit 5ae4c28 into master Dec 9, 2024
@fingolfin
fingolfin deleted the mh/CHANGES branch December 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants