Skip to content

docs: add guide for NextAuth #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2025
Merged

docs: add guide for NextAuth #1730

merged 6 commits into from
Apr 29, 2025

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented May 7, 2024

This pull request enhances the documentation by adding a guide for NextAuth integration. The key changes include a minor text update in the CodeFromRemote component and an updated ordering of sidebar documentation links for various authentication integrations.

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it ❤️

just a few changes, then merge it

Copy link

argos-ci bot commented May 7, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Awaiting the start of a new Argos build…

@aeneasr
Copy link
Member Author

aeneasr commented May 7, 2024

These two need to be merged:

nextauthjs/next-auth#10843
nextauthjs/next-auth-example#99

@aeneasr
Copy link
Member Author

aeneasr commented May 7, 2024

Once merged I would add a notice to the older next js guide that we recommend using next auth instead as the integration is better than with the ory/integrations package.

We should probably de-list the old next-js guide when we do that.

@aeneasr
Copy link
Member Author

aeneasr commented Apr 23, 2025

I think we should go back to this and fix it up!

@aeneasr
Copy link
Member Author

aeneasr commented Apr 29, 2025

Ok, I updated the guide for auth.js v5 and it's working wonderfully now.

@aeneasr aeneasr removed request for zepatrik and piotrmsc April 29, 2025 09:46
@aeneasr aeneasr requested a review from Copilot April 29, 2025 09:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the documentation by adding a guide for NextAuth integration. The key changes include a minor text update in the CodeFromRemote component and an updated ordering of sidebar documentation links for various authentication integrations.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/theme/CodeFromRemote.tsx Updated the anchor text to "See full code on GitHub" to improve text clarity.
src/sidebar.ts Reordered guide links to add "auth-js" and "nextjs" while moving "expressjs" for better navigation.
Files not reviewed (1)
  • docs/getting-started/integrate-auth/14_auth-js.mdx: Language not supported

@aeneasr aeneasr removed the upstream Issue is caused by an upstream dependency. label Apr 29, 2025
@aeneasr
Copy link
Member Author

aeneasr commented Apr 29, 2025

This guide does not need upstream changes to auth.js.

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it ❤️
did not test the example e2e, otherwise looks good to merge to me!

@aeneasr
Copy link
Member Author

aeneasr commented Apr 29, 2025

I did test it :)

@aeneasr aeneasr merged commit 83908a5 into master Apr 29, 2025
10 checks passed
@aeneasr aeneasr deleted the add-nextjs-next branch April 29, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants