Skip to content

WINC-1376: Replace docs.redhat.com for docs.openshift.com #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented May 14, 2025

updates all docs link to redhat.com to the latest version.

@openshift-ci openshift-ci bot requested review from mansikulkarni96 and sebsoto May 14, 2025 14:45
README.md Outdated
@@ -321,7 +321,7 @@ WMCO / Windows nodes does not work with the following products:
* [OpenShift Builds](https://docs.openshift.com/container-platform/latest/cicd/builds/understanding-image-builds.html#understanding-image-builds)
* [OpenShift Pipelines](https://docs.openshift.com/container-platform/latest/cicd/pipelines/understanding-openshift-pipelines.html#understanding-openshift-pipelines)
* [OpenShift Service Mesh](https://docs.openshift.com/container-platform/latest/service_mesh/v2x/ossm-about.html)
* [Red Hat Insights cost management](https://docs.redhat.com/en/documentation/cost_management_service/1-latest)
* [Red Hat Insights cost management](https://docs.openshift.com/en/documentation/cost_management_service/1-latest)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link doesnt work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait a minute, the jira ticket's description is backwards. It's supposed to replace docs.openshift.com with docs.redhat.com

@wgahnagl wgahnagl marked this pull request as draft May 15, 2025 13:47
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2025
@mtnbikenc mtnbikenc changed the title WINC-1376 : Replace docs.redhat.com for docs.openshift.com WINC-1376: Replace docs.redhat.com for docs.openshift.com May 15, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2025

@wgahnagl: This pull request references WINC-1376 which is a valid jira issue.

In response to this:

It seems like this is the only place where the docs were mentioned.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wgahnagl wgahnagl force-pushed the winc-1376 branch 3 times, most recently from 6ec728b to 0a1fd3d Compare May 27, 2025 14:31
@wgahnagl wgahnagl marked this pull request as ready for review May 27, 2025 14:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 27, 2025

@wgahnagl: This pull request references WINC-1376 which is a valid jira issue.

In response to this:

updates all docs link to redhat.com to the latest version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sebsoto May 27, 2025 14:33
// See doc link for explanation of log levels:
// https://docs.openshift.com/container-platform/latest/rest_api/editing-kubelet-log-level-verbosity.html#log-verbosity-descriptions_editing-kubelet-log-level-verbosity
// See doc link for explanation of log levels:\
//https://docs.redhat.com/en/documentation/openshift_container_platform/latest/html/api_overview/editing-kubelet-log-level-verbosity#log-verbosity-descriptions_editing-kubelet-log-level-verbosity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//https://docs.redhat.com/en/documentation/openshift_container_platform/latest/html/api_overview/editing-kubelet-log-level-verbosity#log-verbosity-descriptions_editing-kubelet-log-level-verbosity
// https://docs.redhat.com/en/documentation/openshift_container_platform/latest/html/api_overview/editing-kubelet-log-level-verbosity#log-verbosity-descriptions_editing-kubelet-log-level-verbosity

Copy link
Contributor

@jrvaldes jrvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes, wgahnagl
Once this PR has been reviewed and has the lgtm label, please assign sebsoto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrvaldes
Copy link
Contributor

@wgahnagl, no need to run all the e2e tests in this PR.

Please set the PR back to Draft until it gets the approval, and ask for overrides to avoid the e2e tests.

@wgahnagl wgahnagl marked this pull request as draft May 27, 2025 15:03
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
Copy link
Contributor

openshift-ci bot commented May 27, 2025

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants