Skip to content

fake bump(*) #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
p0lyn0mial wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fake bump(*) #2126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,5 @@ require (
)

replace github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1

replace github.com/openshift/library-go => github.com/p0lyn0mial/library-go v0.0.0-20260427093740-115beeb42338
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check what changes exist in the forked library-go and verify basic compatibility.

echo "=== Checking fork repository details ==="
gh repo view p0lyn0mial/library-go --json name,description,isFork,parent,defaultBranchRef

echo -e "\n=== Checking commit details for pseudo-version ==="
# Pseudo-version format: v0.0.0-YYYYMMDDHHMMSS-commitHash
# Extract commit hash: 115beeb42338 (first 12 chars of commit)
COMMIT_HASH="115beeb42338"
echo "Commit hash from pseudo-version: ${COMMIT_HASH}"
gh api repos/p0lyn0mial/library-go/commits/${COMMIT_HASH} --jq '.commit.message, .commit.author.date, .html_url' 2>/dev/null || echo "Could not fetch commit details (repository may be private or commit hash may be abbreviated)"

echo -e "\n=== Comparing with official library-go version ==="
# Current official version from line 20
OFFICIAL_VERSION="v0.0.0-20260420122951-18e793702c2d"
echo "Official version: ${OFFICIAL_VERSION}"
echo "Fork version: v0.0.0-20260427093740-115beeb42338"
echo "Date difference: Official (2026-04-20) vs Fork (2026-04-27) - fork is 7 days newer"

echo -e "\n=== Checking for breaking changes in library-go APIs ==="
# Check if there are any recent issues or PRs in official library-go that might indicate breaking changes
gh pr list --repo openshift/library-go --search "is:pr is:merged updated:>2026-04-20" --limit 20 --json number,title,mergedAt,url

Repository: openshift/cluster-kube-apiserver-operator

Length of output: 1425

🌐 Web query:

Are there any known breaking changes or API incompatibilities in github.com/openshift/library-go between April 20 and April 27, 2026?

💡 Result:

No, there are no known breaking changes or API incompatibilities in github.com/openshift/library-go between April 20 and April 27, 2026.

Citations:

Confirm the replace directive is for testing only and should not be merged to main.

The replace directive uses a personal fork (github.com/p0lyn0mial/library-go) instead of the official github.com/openshift/library-go. The fork is a legitimate fork of the official repository with a commit adding a mock KMS plugin wrapper binary for testing (authored by RedHat developers). However, personal forks should never be used in production go.mod files merged to main.

Given the PR title "fake bump(*)" and draft status, this is clearly intended for testing. If merging to main is not planned, this is acceptable for development. Otherwise, either:

  • Remove the replace directive before merge, or
  • Replace it with an upstream commit once merged into the official repository

No API compatibility issues were found between the forked version and the current official library-go.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 140, The replace directive "replace
github.com/openshift/library-go => github.com/p0lyn0mial/library-go
v0.0.0-20260427093740-115beeb42338" is a personal-fork override used for testing
(see PR title "fake bump" and draft status); before merging to main either
remove this replace line or update it to point to the official upstream
(github.com/openshift/library-go) at the corresponding commit/semver that
contains the needed mock KMS changes, and ensure go.sum is regenerated (run go
mod tidy) so the module graph contains only approved upstream modules.

4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,11 @@ github.com/openshift/build-machinery-go v0.0.0-20250530140348-dc5b2804eeee h1:+S
github.com/openshift/build-machinery-go v0.0.0-20250530140348-dc5b2804eeee/go.mod h1:8jcm8UPtg2mCAsxfqKil1xrmRMI3a+XU2TZ9fF8A7TE=
github.com/openshift/client-go v0.0.0-20260317180604-743f664b82d1 h1:Hr/R38eg5ZJXfbiaHumjJIN1buDZwhsm4ys4npVCXH0=
github.com/openshift/client-go v0.0.0-20260317180604-743f664b82d1/go.mod h1:Za51LlH76ALiQ/aKGBYJXmyJNkA//IDJ+I///30CA2M=
github.com/openshift/library-go v0.0.0-20260420122951-18e793702c2d h1:qyb9W4WOZM2QFnEFzECG96sPjLyceqY9tdaa+8S0f8k=
github.com/openshift/library-go v0.0.0-20260420122951-18e793702c2d/go.mod h1:pQx73OLgJJtHR2WJVdkH0Zng/yywdL5hmPGw1QbGV/w=
github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1 h1:PMTgifBcBRLJJiM+LgSzPDTk9/Rx4qS09OUrfpY6GBQ=
github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1/go.mod h1:7Du3c42kxCUegi0IImZ1wUQzMBVecgIHjR1C+NkhLQo=
github.com/orisano/pixelmatch v0.0.0-20220722002657-fb0b55479cde/go.mod h1:nZgzbfBr3hhjoZnS66nKrHmduYNpc34ny7RK4z5/HM0=
github.com/p0lyn0mial/library-go v0.0.0-20260427093740-115beeb42338 h1:NNNp4kmbB1z8/DDhOnnpWkQHNkWIaT0r2IOj/lCSFbA=
github.com/p0lyn0mial/library-go v0.0.0-20260427093740-115beeb42338/go.mod h1:pQx73OLgJJtHR2WJVdkH0Zng/yywdL5hmPGw1QbGV/w=
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pkg/profile v1.7.0 h1:hnbDkaNWPCLMO9wGLdBFTIZvzDrDfBM2072E1S9gJkA=
Expand Down
6 changes: 3 additions & 3 deletions vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptionconfig/config.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 13 additions & 13 deletions vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/secrets.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion ...thub.com/openshift/library-go/test/library/encryption/kms/k8s_mock_kms_plugin_deployer.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion vendor/modules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ github.com/openshift/client-go/security/informers/externalversions/internalinter
github.com/openshift/client-go/security/informers/externalversions/security
github.com/openshift/client-go/security/informers/externalversions/security/v1
github.com/openshift/client-go/security/listers/security/v1
# github.com/openshift/library-go v0.0.0-20260420122951-18e793702c2d
# github.com/openshift/library-go v0.0.0-20260420122951-18e793702c2d => github.com/p0lyn0mial/library-go v0.0.0-20260427093740-115beeb42338
## explicit; go 1.25.0
github.com/openshift/library-go/pkg/apiserver/jsonpatch
github.com/openshift/library-go/pkg/assets
Expand Down Expand Up @@ -1696,3 +1696,4 @@ sigs.k8s.io/structured-merge-diff/v6/value
## explicit; go 1.22
sigs.k8s.io/yaml
# github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1
# github.com/openshift/library-go => github.com/p0lyn0mial/library-go v0.0.0-20260427093740-115beeb42338