fake bump(*)#2126
Conversation
|
Skipping CI for Draft Pull Request. |
WalkthroughA Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test |
|
/test e2e-gcp-operator-encryption-kms |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 140: The replace directive "replace github.com/openshift/library-go =>
github.com/p0lyn0mial/library-go v0.0.0-20260427093740-115beeb42338" is a
personal-fork override used for testing (see PR title "fake bump" and draft
status); before merging to main either remove this replace line or update it to
point to the official upstream (github.com/openshift/library-go) at the
corresponding commit/semver that contains the needed mock KMS changes, and
ensure go.sum is regenerated (run go mod tidy) so the module graph contains only
approved upstream modules.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: fd5225cf-4560-4293-a13d-e4f9c26c92ce
⛔ Files ignored due to path filters (8)
go.sumis excluded by!**/*.sumvendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptionconfig/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/secrets.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/library-go/test/library/encryption/kms/k8s_mock_kms_plugin_deployer.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (1)
go.mod
|
|
||
| replace github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1 | ||
|
|
||
| replace github.com/openshift/library-go => github.com/p0lyn0mial/library-go v0.0.0-20260427093740-115beeb42338 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check what changes exist in the forked library-go and verify basic compatibility.
echo "=== Checking fork repository details ==="
gh repo view p0lyn0mial/library-go --json name,description,isFork,parent,defaultBranchRef
echo -e "\n=== Checking commit details for pseudo-version ==="
# Pseudo-version format: v0.0.0-YYYYMMDDHHMMSS-commitHash
# Extract commit hash: 115beeb42338 (first 12 chars of commit)
COMMIT_HASH="115beeb42338"
echo "Commit hash from pseudo-version: ${COMMIT_HASH}"
gh api repos/p0lyn0mial/library-go/commits/${COMMIT_HASH} --jq '.commit.message, .commit.author.date, .html_url' 2>/dev/null || echo "Could not fetch commit details (repository may be private or commit hash may be abbreviated)"
echo -e "\n=== Comparing with official library-go version ==="
# Current official version from line 20
OFFICIAL_VERSION="v0.0.0-20260420122951-18e793702c2d"
echo "Official version: ${OFFICIAL_VERSION}"
echo "Fork version: v0.0.0-20260427093740-115beeb42338"
echo "Date difference: Official (2026-04-20) vs Fork (2026-04-27) - fork is 7 days newer"
echo -e "\n=== Checking for breaking changes in library-go APIs ==="
# Check if there are any recent issues or PRs in official library-go that might indicate breaking changes
gh pr list --repo openshift/library-go --search "is:pr is:merged updated:>2026-04-20" --limit 20 --json number,title,mergedAt,urlRepository: openshift/cluster-kube-apiserver-operator
Length of output: 1425
🌐 Web query:
Are there any known breaking changes or API incompatibilities in github.com/openshift/library-go between April 20 and April 27, 2026?
💡 Result:
No, there are no known breaking changes or API incompatibilities in github.com/openshift/library-go between April 20 and April 27, 2026.
Citations:
- 1: https://github.com/openshift/library-go
- 2: https://github.com/openshift/library-go/releases
- 3: https://github.com/openshift/library-go/commits
- 4: https://github.com/openshift/library-go/tags
Confirm the replace directive is for testing only and should not be merged to main.
The replace directive uses a personal fork (github.com/p0lyn0mial/library-go) instead of the official github.com/openshift/library-go. The fork is a legitimate fork of the official repository with a commit adding a mock KMS plugin wrapper binary for testing (authored by RedHat developers). However, personal forks should never be used in production go.mod files merged to main.
Given the PR title "fake bump(*)" and draft status, this is clearly intended for testing. If merging to main is not planned, this is acceptable for development. Otherwise, either:
- Remove the replace directive before merge, or
- Replace it with an upstream commit once merged into the official repository
No API compatibility issues were found between the forked version and the current official library-go.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 140, The replace directive "replace
github.com/openshift/library-go => github.com/p0lyn0mial/library-go
v0.0.0-20260427093740-115beeb42338" is a personal-fork override used for testing
(see PR title "fake bump" and draft status); before merging to main either
remove this replace line or update it to point to the official upstream
(github.com/openshift/library-go) at the corresponding commit/semver that
contains the needed mock KMS changes, and ensure go.sum is regenerated (run go
mod tidy) so the module graph contains only approved upstream modules.
|
@p0lyn0mial: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
test for openshift/library-go#2173
Summary by CodeRabbit