Skip to content

fake bump(*)#2126

Draft
p0lyn0mial wants to merge 1 commit into
openshift:mainfrom
p0lyn0mial:test-2173
Draft

fake bump(*)#2126
p0lyn0mial wants to merge 1 commit into
openshift:mainfrom
p0lyn0mial:test-2173

Conversation

@p0lyn0mial
Copy link
Copy Markdown
Contributor

@p0lyn0mial p0lyn0mial commented Apr 27, 2026

test for openshift/library-go#2173

Summary by CodeRabbit

  • Chores
    • Updated an internal dependency to use an alternative module source during builds and testing.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Walkthrough

A replace directive is added to go.mod, redirecting imports of github.com/openshift/library-go to the module github.com/p0lyn0mial/library-go at pseudo-version v0.0.0-20260427093740-115beeb42338. This alters dependency resolution during builds and tests.

Changes

Cohort / File(s) Summary
Go Module Replace Directive
go.mod
Added a replace directive to redirect github.com/openshift/library-go to a forked version at github.com/p0lyn0mial/library-go.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fake bump(*)' is vague and uses non-descriptive terms that do not clearly convey the meaningful information about the changeset, which involves introducing a Go module replace directive for dependency resolution. Replace the vague title with a clear, specific description of the main change, such as 'Replace openshift/library-go dependency with p0lyn0mial fork' or 'Add go.mod replace directive for library-go module'.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The custom check for stable and deterministic Ginkgo test names is not applicable to this pull request. The PR only modifies go.mod for dependency management.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test structure is not applicable; the PR only modifies go.mod with no changes to test files.
Microshift Test Compatibility ✅ Passed This PR only modifies go.mod with a dependency replace directive and does not introduce any new Ginkgo e2e tests, making this check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies go.mod to add replace directives for dependencies and does not add any new Ginkgo e2e tests. The custom check for SNO test compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only modifies go.mod with a replace directive, not deployment manifests, operator code, or controllers with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The custom check for OTE Binary Stdout Contract violations is not applicable to this PR. The PR only modifies the go.mod file with a dependency replace directive and introduces no source code changes that could violate stdout communication contracts.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies go.mod with a replace directive; no Ginkgo e2e tests were added or modified, making this check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2026
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

/test

@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-operator-encryption-kms

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 140: The replace directive "replace github.com/openshift/library-go =>
github.com/p0lyn0mial/library-go v0.0.0-20260427093740-115beeb42338" is a
personal-fork override used for testing (see PR title "fake bump" and draft
status); before merging to main either remove this replace line or update it to
point to the official upstream (github.com/openshift/library-go) at the
corresponding commit/semver that contains the needed mock KMS changes, and
ensure go.sum is regenerated (run go mod tidy) so the module graph contains only
approved upstream modules.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fd5225cf-4560-4293-a13d-e4f9c26c92ce

📥 Commits

Reviewing files that changed from the base of the PR and between df4cff1 and 9720586.

⛔ Files ignored due to path filters (8)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/key_controller.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/encryptionconfig/config.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/secrets.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/secrets/types.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/state/types.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/test/library/encryption/kms/k8s_mock_kms_plugin_deployer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod

replace github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1

replace github.com/openshift/library-go => github.com/p0lyn0mial/library-go v0.0.0-20260427093740-115beeb42338
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check what changes exist in the forked library-go and verify basic compatibility.

echo "=== Checking fork repository details ==="
gh repo view p0lyn0mial/library-go --json name,description,isFork,parent,defaultBranchRef

echo -e "\n=== Checking commit details for pseudo-version ==="
# Pseudo-version format: v0.0.0-YYYYMMDDHHMMSS-commitHash
# Extract commit hash: 115beeb42338 (first 12 chars of commit)
COMMIT_HASH="115beeb42338"
echo "Commit hash from pseudo-version: ${COMMIT_HASH}"
gh api repos/p0lyn0mial/library-go/commits/${COMMIT_HASH} --jq '.commit.message, .commit.author.date, .html_url' 2>/dev/null || echo "Could not fetch commit details (repository may be private or commit hash may be abbreviated)"

echo -e "\n=== Comparing with official library-go version ==="
# Current official version from line 20
OFFICIAL_VERSION="v0.0.0-20260420122951-18e793702c2d"
echo "Official version: ${OFFICIAL_VERSION}"
echo "Fork version: v0.0.0-20260427093740-115beeb42338"
echo "Date difference: Official (2026-04-20) vs Fork (2026-04-27) - fork is 7 days newer"

echo -e "\n=== Checking for breaking changes in library-go APIs ==="
# Check if there are any recent issues or PRs in official library-go that might indicate breaking changes
gh pr list --repo openshift/library-go --search "is:pr is:merged updated:>2026-04-20" --limit 20 --json number,title,mergedAt,url

Repository: openshift/cluster-kube-apiserver-operator

Length of output: 1425


🌐 Web query:

Are there any known breaking changes or API incompatibilities in github.com/openshift/library-go between April 20 and April 27, 2026?

💡 Result:

No, there are no known breaking changes or API incompatibilities in github.com/openshift/library-go between April 20 and April 27, 2026.

Citations:


Confirm the replace directive is for testing only and should not be merged to main.

The replace directive uses a personal fork (github.com/p0lyn0mial/library-go) instead of the official github.com/openshift/library-go. The fork is a legitimate fork of the official repository with a commit adding a mock KMS plugin wrapper binary for testing (authored by RedHat developers). However, personal forks should never be used in production go.mod files merged to main.

Given the PR title "fake bump(*)" and draft status, this is clearly intended for testing. If merging to main is not planned, this is acceptable for development. Otherwise, either:

  • Remove the replace directive before merge, or
  • Replace it with an upstream commit once merged into the official repository

No API compatibility issues were found between the forked version and the current official library-go.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 140, The replace directive "replace
github.com/openshift/library-go => github.com/p0lyn0mial/library-go
v0.0.0-20260427093740-115beeb42338" is a personal-fork override used for testing
(see PR title "fake bump" and draft status); before merging to main either
remove this replace line or update it to point to the official upstream
(github.com/openshift/library-go) at the corresponding commit/semver that
contains the needed mock KMS changes, and ensure go.sum is regenerated (run go
mod tidy) so the module graph contains only approved upstream modules.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

@p0lyn0mial: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-encryption-kms-ote 9720586 link true /test e2e-gcp-operator-encryption-kms-ote

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant