Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: retry image pull in all cases #733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-ISSUE: retry image pull in all cases #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions internal/precache/workload/pullImages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"fmt"
"os"
"strconv"
"strings"
"sync"

log "github.com/sirupsen/logrus"
Expand Down Expand Up @@ -86,10 +85,6 @@ func pullImage(image, authFile string, progress *precache.Progress) error {
} else {
message := fmt.Sprintf("%v", err)
log.Infof("Attempt %d/%d: Failed to pull %s: %s", i+1, MaxRetries, image, message)
if strings.Contains(message, "manifest unknown") {
// no point to retry if we can reach the registry and the digest doesn't exist
break
}
}
}
// update precache progress tracker
Expand Down