Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: retry image pull in all cases #733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Jan 29, 2025

NO-ISSUE: in some registries (brew for example) we can get a redirect to another registry that doesn't have this specific image manifest and we will get manifest-unknown error and will not retry to pull it, removing this pretty small optimisation will allow us to retry in this case and make our code more error resilient

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

another registry that doesn't have this specific image manifest and we
will get manifest-unknown error and will not retry to pull it, removing
this pretty small optimisation will allow us to retry in this case and
make our code more error resilient
@openshift-ci-robot
Copy link

@tsorya: This pull request explicitly references no jira issue.

In response to this:

NO-ISSUE: in some registries (brew for example) we can get a redirect to another registry that doesn't have this specific image manifest and we will get manifest-unknown error and will not retry to pull it, removing this pretty small optimisation will allow us to retry in this case and make our code more error resilient

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tsorya. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omertuc
Copy link
Collaborator

omertuc commented Jan 29, 2025

Why would retrying suddenly fix this? - Is the registry redirect temporary?

@eranco74
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@tsorya
Copy link
Contributor Author

tsorya commented Jan 29, 2025

/retest

Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

@tsorya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibu-e2e-flow 473b1de link false /test ibu-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants