Fix XPathMatcher to support text() predicate in XPath expressions
#6315
+89
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CONDITION_CONJUNCTION_PATTERN regex was missing support for text() function, causing RemoveXmlTag to ignore text predicates and remove all matching elements instead of only those with specific text content. Fixes #6314 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
timtebeek
changed the title
XPathMatcher to support text() predicate in XPath expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
text()function support to XPathMatcher's CONDITION_CONJUNCTION_PATTERN regexHandle
text()predicate evaluation by checking tag's text contentAdd comprehensive test coverage for text() predicates in XPathMatcherTest and RemoveXmlTagTest
Fixes RemoveXmlTag does not correctly evaluate XPath #6314
Closes Remove XML tag if it matches the content given in the xPath #4686
Test plan
XPathMatcherTest.matchTextFunctionCondition()- verifies text() predicate matchingRemoveXmlTagTest.removeOnlyElementMatchingTextPredicate()- verifies only elements with matching text are removedRemoveXmlTagTest.removeOnlyElementMatchingLocalNameAndTextPredicate()- verifies combined predicates work🤖 Generated with Claude Code