Fix XPathMatcher to support text() predicate in XPath expressions (#6315)

The CONDITION_CONJUNCTION_PATTERN regex was missing support for text()
function, causing RemoveXmlTag to ignore text predicates and remove all
matching elements instead of only those with specific text content.

Fixes #6314

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <[email protected]>

Author: timtebeek

rewrite-xml/src/main/java/org/openrewrite/xml/XPathMatcher.java

@@ -44,7 +44,7 @@ public class XPathMatcher {
     // Regular expression to support conditional tags like `plugin[artifactId='maven-compiler-plugin']` or foo[@bar='baz']
     private static final Pattern ELEMENT_WITH_CONDITION_PATTERN = Pattern.compile("(@)?([-:\\w]+|\\*)(\\[.+])");
     private static final Pattern CONDITION_PATTERN = Pattern.compile("(\\[.*?])+?");
-    private static final Pattern CONDITION_CONJUNCTION_PATTERN = Pattern.compile("(((local-name|namespace-uri)\\(\\)|(@)?([-\\w:]+|\\*))\\h*=\\h*[\"'](.*?)[\"'](\\h?(or|and)\\h?)?)+?");
+    private static final Pattern CONDITION_CONJUNCTION_PATTERN = Pattern.compile("(((local-name|namespace-uri|text)\\(\\)|(@)?([-\\w:]+|\\*))\\h*=\\h*[\"'](.*?)[\"'](\\h?(or|and)\\h?)?)+?");
 
     private final String expression;
     private final boolean startsWithSlash;
@@ -296,8 +296,10 @@ private boolean matchesWithoutDoubleSlashesAt(Cursor cursor, int doubleSlashInde
                             break;
                         }
                     }
-                } else if (isFunctionCondition) { // [local-name()='name'] pattern
-                    if (isAttributeElement) {
+                } else if (isFunctionCondition) { // [local-name()='name'] or [text()='value'] pattern
+                    if ("text()".equals(selector)) {
+                        matchCurrentCondition = tag.getValue().map(v -> v.equals(value)).orElse(false);
+                    } else if (isAttributeElement) {
                         for (Xml.Attribute a : tag.getAttributes()) {
                             if (matchesElementAndFunction(new Cursor(cursor, a), element, selector, value)) {
                                 matchCurrentCondition = true;

rewrite-xml/src/test/java/org/openrewrite/xml/RemoveXmlTagTest.java

@@ -17,6 +17,7 @@
 
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
+import org.openrewrite.Issue;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
 
@@ -102,6 +103,52 @@ void fileMatcherEmpty() {
         );
     }
 
+    @Test
+    @Issue("https://github.com/openrewrite/rewrite/issues/6314")
+    void removeOnlyElementMatchingTextPredicate() {
+        rewriteRun(
+          spec -> spec.recipe(new RemoveXmlTag("/test/foo[text()='bar']", null)),
+          xml(
+            """
+              <test>
+                  <foo>bar</foo>
+                  <foo>notBar</foo>
+                  <foo/>
+              </test>
+              """,
+            """
+              <test>
+                  <foo>notBar</foo>
+                  <foo/>
+              </test>
+              """
+          )
+        );
+    }
+
+    @Test
+    @Issue("https://github.com/openrewrite/rewrite/issues/6314")
+    void removeOnlyElementMatchingLocalNameAndTextPredicate() {
+        rewriteRun(
+          spec -> spec.recipe(new RemoveXmlTag("/test/*[local-name()='foo' and text()='bar']", null)),
+          xml(
+            """
+              <test>
+                  <foo>bar</foo>
+                  <foo>notBar</foo>
+                  <foo/>
+              </test>
+              """,
+            """
+              <test>
+                  <foo>notBar</foo>
+                  <foo/>
+              </test>
+              """
+          )
+        );
+    }
+
     @Test
     void removeEmptyParentTag() {
         rewriteRun(

rewrite-xml/src/test/java/org/openrewrite/xml/XPathMatcherTest.java

@@ -412,6 +412,43 @@ void matchMultipleConditions() {
         assertThat(match("//*[@ns3:attr='test2'][local-name()='element4'][namespace-uri()='http://www.example.com/namespaceX']", namespacedXml)).isFalse();
     }
 
+    @Test
+    @Issue("https://github.com/openrewrite/rewrite/issues/6314")
+    void matchTextFunctionCondition() {
+        SourceFile xml = new XmlParser().parse(
+          """
+            <?xml version="1.0" encoding="UTF-8"?>
+            <test>
+              <foo>bar</foo>
+              <foo>notBar</foo>
+              <foo/>
+            </test>
+            """
+        ).toList().getFirst();
+
+        // text() predicate should only match element with specific text content
+        assertThat(match("/test/foo[text()='bar']", xml)).isTrue();
+        assertThat(match("/test/foo[text()='notBar']", xml)).isTrue();
+        assertThat(match("/test/foo[text()='nonexistent']", xml)).isFalse();
+        assertThat(match("//foo[text()='bar']", xml)).isTrue();
+        assertThat(match("//foo[text()='notBar']", xml)).isTrue();
+        assertThat(match("//foo[text()='nonexistent']", xml)).isFalse();
+
+        // wildcard element with text() predicate
+        assertThat(match("/test/*[text()='bar']", xml)).isTrue();
+        assertThat(match("//*[text()='bar']", xml)).isTrue();
+        assertThat(match("//*[text()='notBar']", xml)).isTrue();
+
+        // combining text() with local-name()
+        assertThat(match("//*[local-name()='foo' and text()='bar']", xml)).isTrue();
+        assertThat(match("//*[local-name()='foo' and text()='notBar']", xml)).isTrue();
+        assertThat(match("//*[local-name()='foo' and text()='nonexistent']", xml)).isFalse();
+
+        // combining text() with or
+        assertThat(match("/test/foo[text()='bar' or text()='notBar']", xml)).isTrue();
+        assertThat(match("/test/foo[text()='nonexistent' or text()='bar']", xml)).isTrue();
+    }
+
     @Test
     void matchConditionsWithConjunctions() {
         // T&T, T&F, F&T, F&F