add tests and handling for deleted users #953
Merged
+115
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishv7
changed the title
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
Datadog ReportBranch report: ✅ 0 Failed, 261 Passed, 36 Skipped, 44.77s Total Time |
harishv7
force-pushed
the
12-20-add_tests_for_soft_delete
branch
from
23cf858 to
e611093
Compare
adriangohjw
reviewed
Jan 13, 2025
apps/studio/src/server/modules/user/__tests__/user.service.test.ts
Outdated
Show resolved
Hide resolved
apps/studio/src/server/modules/user/__tests__/user.service.test.ts
Outdated
Show resolved
Hide resolved
harishv7
force-pushed
the
12-20-soft_delete_for_user_and_perms
branch
from
6f97b13 to
11d220c
Compare
harishv7
force-pushed
the
12-20-add_tests_for_soft_delete
branch
from
e611093 to
70ea755
Compare
adriangohjw
approved these changes
Jan 15, 2025
harishv7
force-pushed
the
12-20-add_tests_for_soft_delete
branch
from
e646066 to
acae41e
Compare
harishv7
force-pushed
the
12-20-soft_delete_for_user_and_perms
branch
from
dafdc69 to
36c7549
Compare
harishv7
force-pushed
the
12-20-add_tests_for_soft_delete
branch
from
acae41e to
75281ae
Compare
Merge activity
|
harishv7
merged commit 04ca4f5
into
12-20-soft_delete_for_user_and_perms
13 of 15 checks passed
harishv7
added a commit
that referenced
this pull request
Jan 23, 2025
* add tests for soft delete * add tests for list site * add test for login * fix pr comments * default values for non-essential fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Deleted users were still able to access the system and view sites they previously had access to.
Closes ISOM-1701
Solution
Added checks to prevent deleted users from logging in and viewing sites they previously had access to.
Breaking Changes:
Features:
Improvements:
Tests
New scripts:
None
New dependencies:
None
New dev dependencies:
None