default values for non-essential fields

opengovsg · Jan 23, 2025 · acae41e · acae41e
1 parent 3173ea5
commit acae41e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/apps/studio/src/server/modules/user/__tests__/user.service.test.ts b/apps/studio/src/server/modules/user/__tests__/user.service.test.ts
@@ -13,10 +13,7 @@ describe("user.service", () => {
     const email = "[email protected]"
     // Setup active user
     await setupUser({
-      name: "Active User",
-      userId: "active123",
       email: email,
-      phone: "12345678",
       isDeleted: false,
     })
 
@@ -31,10 +28,7 @@ describe("user.service", () => {
     const email = "[email protected]"
     // Setup deleted user
     await setupUser({
-      name: "Deleted User",
-      userId: "deleted123",
       email: email,
-      phone: "12345678",
       isDeleted: true,
     })
 

diff --git a/apps/studio/tests/integration/helpers/seed/index.ts b/apps/studio/tests/integration/helpers/seed/index.ts
@@ -444,14 +444,14 @@ export const setUpWhitelist = async ({
 }
 
 export const setupUser = async ({
-  name,
-  userId,
+  name = "Test User",
+  userId = nanoid(),
   email,
-  phone,
+  phone = "",
   isDeleted,
 }: {
-  name: string
-  userId: string
+  name?: string
+  userId?: string
   email: string
   phone?: string
   isDeleted: boolean
@@ -462,7 +462,7 @@ export const setupUser = async ({
       id: userId,
       name,
       email,
-      phone: phone ?? "",
+      phone: phone,
       deletedAt: isDeleted ? new Date() : null,
     })
     .returningAll()