Add 'Voucher:' before voucher code on order confirmation emails

[kernal053]

What? Why?

• Closes Add "voucher:" before voucher code on order confirmation emails #12978

What should we test?

• When voucher is used in an order as a shopper, order confirmation email will contain "Voucher:" text before voucher code.
• Check also for translated "Voucher" text.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Preview (en)

Preview (es)

[mkllnk]

Nice! Thank you.

I have a suggestion below. Are you up for that?

[dacook]

Thanks, that's a good solution.

But actually we prefer not to change all the locale files, only en.yml. All other files are managed with Transifex and shouldn't be updated directly, so this could cause conflicts. Could you please remove those changes?

For reference:
https://github.com/openfoodfoundation/openfoodnetwork/wiki/Internationalisation-%28i18n%29#development

[rioug]

Nice one 👍 Thanks @kernal053 🙏

[dacook]

Thankyou!

[dacook]

Hmm, sorry I didn't notice this earlier, but this will hide any adjustments that are not of type "Voucher".
I'm not sure, but I think other adjustments such as Enterprise Fees or tax might appear here.

If so, it would be worth adding a spec here: https://guide.openfoodnetwork.org/basic-features/shopfront/enterprise-fees

Are you willing to look into this?

[kernal053]

Apologies, I overlook other adjustments. Will fix the code. Right now, we're only excluding LineItem adjustable. Thereby, not displaying enterprise fees.

And adding spec, I think order_mailer_spec.rb needs to be updated. I couldn't get around your message regarding it. I guess you meant to mention specific spec file.

[dacook]

Thanks for looking back into this.

And adding spec, I think order_mailer_spec.rb needs to be updated. I couldn't get around your message regarding it. I guess you meant to mention specific spec file.

I'm sorry, I pasted the wrong link. You're right, it was meant to be a link to order_mailer_spec.rb 👍

[rioug]

Looks good, thanks @kernal053 🙏

[dacook]

Great!

[dacook]

I see that the shipping fee comes from the factory order_with_totals_and_distribution. Maybe it's worth a comment here explaining that, but never mind :)

[drummer83]

Hi @kernal053,
Thank you so much for working on this. Due to the holiday season it took a while until we got to testing it - I'm sorry for that.

I've tested your PR now and here are the results.

Tested page
Order summary page
Before:	After:
Edit cart page
Before:	After:
Order confirmation page
Before:	After:
Order confirmation email
Before:	After:

Results

A few things are worth mentioning.

• As expected, the order confirmation email is now including the 'Voucher' prefix. 🎉 💪 Excellent!
• We can see that the format is slightly different to what was specified and what is used in other places. Instead of a colon we have brackets here now. It's a minor issue, not blocking the merging of your PR. ➡️ Unify format of 'Voucher:' prefix in order confirmation email #13060
• We can see that we are still missing the 'Voucher:' prefix on the edit cart page. This is out of scope for this issue, so also no block for merging your PR. ➡️ Add 'Voucher:' before voucher code on edit cart page #13059

Summary

Your PR is solving the issue well. I will open new issues to address the remaining two minor things I've found. If you like, feel free to tackle them as well.

Thank you so much again! 🙏
Merging! 🥳 🚀