Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify format of 'Voucher:' prefix in order confirmation email #13060

Closed
drummer83 opened this issue Jan 3, 2025 · 2 comments
Closed

Unify format of 'Voucher:' prefix in order confirmation email #13060

drummer83 opened this issue Jan 3, 2025 · 2 comments
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@drummer83
Copy link
Contributor

Description

Follow up of #12998.

We have a 'Voucher:' prefix before the voucher code in most places where the voucher amount is displayed. However, this prefix has a different format in the order confirmation email.

Expected Behavior

The format should be Voucher: CODE everywhere.

Actual Behaviour

In order confirmation emails the format is Voucher (CODE):.

Steps to Reproduce

  1. Place an order using a voucher code.
  2. Look at the format in the order confirmation email.

Animated Gif/Screenshot

What it looks like in the order confirmation emails:
grafik

What it looks like in other places:
grafik

Workaround

Severity

bug-s4: it's annoying, but you can use it

Your Environment

  • Version used:
  • Browser name and version:
  • Operating System and version (desktop or mobile):

Possible Fix

@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Jan 3, 2025
@drummer83 drummer83 added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Jan 3, 2025
@github-project-automation github-project-automation bot moved this to To triage (By the maintainers) in Welcome New Developers! Jan 3, 2025
@drummer83 drummer83 moved this from To triage (By the maintainers) to Frontend Easy in Welcome New Developers! Jan 3, 2025
@kernal053
Copy link
Contributor

I had implemented 'Voucher:' prefix format for these email earlier but it looked odd with double colon.

389878590-ad148546-1138-41bc-a854-16ef8d82ba97

 
Do you have suggestions to implement this prefix format with styling changes for order summary section (i.e without use of colon) ?

@drummer83 drummer83 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2025
@github-project-automation github-project-automation bot moved this from All the things 💤 to Done in OFN Delivery board Jan 4, 2025
@github-project-automation github-project-automation bot moved this from Frontend Easy to Done in Welcome New Developers! Jan 4, 2025
@drummer83
Copy link
Contributor Author

Hmm, indeed, it looks strange...
I think your implementation is fine then. Closing here.
Thank you, @kernal053! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
Status: Done
Development

No branches or pull requests

2 participants