Skip to content

Add Namespace to Secret type #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Add Namespace to Secret type #1334

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c191ea1
Add Namespace to Secret type
Oct 3, 2019
686b8fb
Remove duplicated Secret struct
Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions gateway/requests/requests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ type DeleteFunctionRequest struct {

// Secret for underlying orchestrator
type Secret struct {
Name string `json:"name"`
Value string `json:"value,omitempty"`
Name string `json:"name"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using the Secret struct from faas, if we have it in faas-provider too? Can we delete this copy?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, took a look here and it's not being used anywhere. Removing it.

Namespace string `json:"namespace"`
Value string `json:"value,omitempty"`
}