Add Namespace to Secret type #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonatas Baldin <[email protected]>
This was referenced Oct 3, 2019
alexellis
reviewed
Oct 3, 2019
gateway/requests/requests.go
Outdated
| @@ -19,6 +19,7 @@ type DeleteFunctionRequest struct { | |||
|
|
|||
| // Secret for underlying orchestrator | |||
| type Secret struct { | |||
| Name string `json:"name"` | |||
| Value string `json:"value,omitempty"` | |||
| Name string `json:"name"` | |||
There was a problem hiding this comment.
Why are we using the Secret struct from faas, if we have it in faas-provider too? Can we delete this copy?
There was a problem hiding this comment.
Yeah, took a look here and it's not being used anywhere. Removing it.
Signed-off-by: Jonatas Baldin <[email protected]>
|
Can I update the |
|
Sure, I cut a new release for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonatas Baldin [email protected]
Description
Enables Namespace in Secret. Depends on faas-provider #28.
Motivation and Context
design/approvedlabelTypes of changes
Checklist:
git commit -s