Adds pointer tag parsing implementation in parse_xml
#830
+261
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttqureshi
force-pushed
the
ttqureshi/pointer-tag
branch
2 times, most recently
from
b3eb22a to
5e0828f
Compare
|
This PR is ready for review. |
8 tasks
farhan
requested changes
Apr 7, 2025
ttqureshi
force-pushed
the
ttqureshi/pointer-tag
branch
from
15c9d82 to
cd7ba89
Compare
farhan
requested changes
Apr 8, 2025
ttqureshi
force-pushed
the
ttqureshi/pointer-tag
branch
5 times, most recently
from
fd3b0eb to
d247d0d
Compare
farhan
reviewed
Apr 9, 2025
farhan
reviewed
Apr 9, 2025
farhan
reviewed
Apr 9, 2025
farhan
reviewed
Apr 9, 2025
ttqureshi
force-pushed
the
ttqureshi/pointer-tag
branch
from
bc0a1f5 to
fe49706
Compare
farhan
approved these changes
Apr 10, 2025
|
I didn't test this PR manually, I am trusting Tayyab good domain knowledge and testing on it |
|
@kdmccormick |
ttqureshi
force-pushed
the
ttqureshi/pointer-tag
branch
from
fe49706 to
d8f02a9
Compare
|
Yep, this is in my queue Tayyab, sorry for my slowness. |
No worries |
kdmccormick
requested changes
May 6, 2025
Comment on lines
+64
to
+81
| def load_definition_xml(node, runtime, def_id): | ||
| """ | ||
| Parses and loads an XML definition file based on a given node, runtime | ||
| environment, and definition ID. | ||
|
|
||
| Arguments: | ||
| node: XML element containing attributes for definition loading. | ||
| runtime: The runtime environment that provides resource access. | ||
| def_id: Unique identifier for the definition being loaded. | ||
|
|
||
| Returns: | ||
| tuple: A tuple containing the loaded XML definition and the | ||
| corresponding file path. | ||
| """ | ||
| url_name = node.get('url_name') | ||
| filepath = format_filepath(node.tag, name_to_pathname(url_name)) | ||
| definition_xml = load_file(filepath, runtime.resources_fs, def_id) | ||
| return definition_xml, filepath |
There was a problem hiding this comment.
Would this work in xblock-sdk as well, or is this logic specific to edx-platform?
If it is specific to edx-platform, then we want want to go through a Runtime method instead, so that edx-platform and xblock-sdk can implement it differently.
Co-authored-by: Kyle McCormick <[email protected]>
ttqureshi
force-pushed
the
ttqureshi/pointer-tag
branch
from
6139828 to
8f6f7e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation has been taken from
XmlMixin's pointer tags parsing logic.Testing Notes:
Overall bug investigation ticket: openedx/edx-platform#36390