Skip to content

feat: Extracting LTI XBlock from edx-platform #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

ttqureshi
Copy link

@ttqureshi ttqureshi commented Oct 21, 2024

Ticket
LTI Block Extraction from the edx-platform.

Test PR

Here's the Test PR for extracted LTIBlock

File References

Acceptance Criteria

  • Extracted XBlock user experience should behave normal if required global css variables donesn't exist
  • Extracted XBlock funcationality should work fine after turning its relevant Django Settings Flag
  • In existing built in xblock implementation of edx-platform, update the status or data of the XBlocks. Then change the Django Settings flag and verify after shifting to extracted one, XBlocks are maintaining their required states (including XBlock completion status).
  • Also test the vice versa of above step, change XBlock from Extracted one to Built in implementation to check fallback case testings.
  • i18n is supported in the XBlock
  • Create a course, add multiple XBlocks in the course. Keep different XBlocks in diversity of states (done/un-done etc). Export the course then validate the XBlock states after importing it again.
  • Make a test PR for the extracted Block in edx-platform like this and fix the test cases if required.
  • Write further unit test cases for good code coverage

@ttqureshi ttqureshi force-pushed the ttqureshi/lti-xblock branch 2 times, most recently from 4edd302 to cb9b866 Compare October 24, 2024 11:56
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-xblock branch from e7ac22e to fe9f7ae Compare October 31, 2024 08:43
@ttqureshi ttqureshi changed the title feat: Extracting LTI xblock from edx-platform feat: Extracting LTI XBlock from edx-platform Nov 6, 2024
@ttqureshi ttqureshi marked this pull request as draft November 8, 2024 07:24
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-xblock branch from da8ea4b to db93aa9 Compare November 18, 2024 07:55
@ttqureshi ttqureshi marked this pull request as ready for review November 25, 2024 09:12
@ttqureshi ttqureshi marked this pull request as draft November 25, 2024 09:12
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-xblock branch 2 times, most recently from 5316400 to 1a4e644 Compare November 25, 2024 10:00
@ttqureshi ttqureshi marked this pull request as ready for review November 25, 2024 10:02
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-xblock branch from 658ee73 to 4ab1d52 Compare November 27, 2024 07:53
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-xblock branch 2 times, most recently from d6b7081 to 4ab1d52 Compare December 30, 2024 09:28
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-xblock branch from 28d6fcc to 0125b23 Compare February 18, 2025 06:56
- update selector in css to render iframe properly
- update identifier in js to find LTI element
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-xblock branch from 6e5ca6e to 42987fb Compare February 20, 2025 12:31
@ttqureshi
Copy link
Author

Currently blocked on: openedx/XBlock#823

PR link: openedx/XBlock#830.

@ttqureshi
Copy link
Author

ttqureshi commented Apr 18, 2025

This PR is up for review

cc: @farhan @salman2013 @irtazaakram

@kdmccormick kdmccormick self-requested a review April 21, 2025 15:30
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Before merging can you update the xblocks-contrib README so that it says this block is "In Development" instead of "Placeholder"? Can you do the same for annotatable and word_cloud too? (we forgot to update the list for those)

@ttqureshi
Copy link
Author

ttqureshi commented May 7, 2025

Before merging can you update the xblocks-contrib README so that it says this block is "In Development" instead of "Placeholder"? Can you do the same for annotatable and word_cloud too? (we forgot to update the list for those)

sure

@ttqureshi
Copy link
Author

@kdmccormick I've made the requested changes, bumped the minor version and added the CHANGELOG entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants