-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Extracting LTI XBlock from edx-platform #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4edd302
to
cb9b866
Compare
e7ac22e
to
fe9f7ae
Compare
da8ea4b
to
db93aa9
Compare
5316400
to
1a4e644
Compare
658ee73
to
4ab1d52
Compare
d6b7081
to
4ab1d52
Compare
28d6fcc
to
0125b23
Compare
- Defined constants for anonymous user ID and user role. - Replaced HTML/Text helpers with markupsafe.
6e5ca6e
to
42987fb
Compare
d61fe48
to
0db139a
Compare
Currently blocked on: openedx/XBlock#823 PR link: openedx/XBlock#830. |
This PR is up for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Before merging can you update the xblocks-contrib README so that it says this block is "In Development" instead of "Placeholder"? Can you do the same for annotatable and word_cloud too? (we forgot to update the list for those)
sure |
Co-authored-by: Kyle McCormick <[email protected]>
- set the status for `word_cloud`, `annotatable` and `lti` blocks
@kdmccormick I've made the requested changes, bumped the minor version and added the |
Ticket
LTI Block Extraction from the edx-platform.
Test PR
Here's the Test PR for extracted LTIBlock
File References
xblocks-contrib/lti/lti.py
has been extracted fromedx-platform/xmodule/lti_block.py
xblocks-contrib/lti/lti_2_util.py
has been extracted fromedx-platform/xmodule/lti_2_util.py
xblocks_contrib/lti/static/css/lti.css
has been extracted fromedx-platform/xmodule/static/css-builtin-blocks/LTIBlockDisplay.css
xblocks_contrib/lti/static/js/src/lti.js
has been extracted fromedx-platform/xmodule/js/src/lti/lti.js
xblocks_contrib/lti/templates/lti.html
has been extracted fromedx-platform/lms/templates/lti.html
xblocks_contrib/lti/templates/lti_form.html
has been extracted fromedx-platform/lms/templates/lti_form.html
Acceptance Criteria