-
-
Notifications
You must be signed in to change notification settings - Fork 667
fix: List items for a conversation. file_id is null and file_data is not present in the API response
#715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… is not present in the API response.
|
By another service you mean not-OpenAI? The nulling of more fields will probably fail since tests expect those non-null, but I enabled build for you to see that. |
It goes through the OpenAI API but via a python script. Here is an example: Thank you for enabling the tests, I will adapt them. @iBotPeaches |
iBotPeaches
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add 2 tests for the old form (string) and new (missing or null).
Sorry that a base test doesn't exist for ContentInputFile, but looking at this directory you should see its pretty simple to do
https://github.com/openai-php/client/tree/main/tests/Responses/Responses/Input
Hello @iBotPeaches I've added some tests. I'm not very comfortable with Pest; I hope this is what was expected. |
|
thanks! |
|
thanks to u @iBotPeaches |
What:
Description:
Context: We want to retrieve conversations that were created via another service. In that service, when the API is called, the "input_file" values are transmitted in base64.
When I try to list items for a conversation, I encounter an error:
Below is the raw API response (data has been masked), we can see that
file_idis equal tonulland thatfile_datais missing.