fix(OpenAI): List items for a conversation. file_id is null and file_data is not present in the API response (#715)

* fix: List items for a conversation. `file_id` is null and `file_data` is not present in the API response.

* update

* add tests

`php -d memory_limit=512M ./vendor/bin/pest --colors=always`

* single_blank_line_at_eof

Author: romainnorberg

src/Responses/Responses/Input/InputMessageContentInputFile.php

@@ -9,7 +9,7 @@
 use OpenAI\Testing\Responses\Concerns\Fakeable;
 
 /**
- * @phpstan-type ContentInputFileType array{type: 'input_file', file_data: string, file_id: string, filename: string}
+ * @phpstan-type ContentInputFileType array{type: 'input_file', file_data: ?string, file_id: ?string, filename: string}
  *
  * @implements ResponseContract<ContentInputFileType>
  */
@@ -27,8 +27,8 @@ final class InputMessageContentInputFile implements ResponseContract
      */
     private function __construct(
         public readonly string $type,
-        public readonly string $fileData,
-        public readonly string $fileId,
+        public readonly ?string $fileData,
+        public readonly ?string $fileId,
         public readonly string $filename,
     ) {}
 
@@ -39,8 +39,8 @@ public static function from(array $attributes): self
     {
         return new self(
             type: $attributes['type'],
-            fileData: $attributes['file_data'],
-            fileId: $attributes['file_id'],
+            fileData: $attributes['file_data'] ?? null,
+            fileId: $attributes['file_id'] ?? null,
             filename: $attributes['filename'],
         );
     }

tests/Fixtures/Responses.php

@@ -307,6 +307,31 @@ function mcpApprovalResponseItem(): array
     ];
 }
 
+/**
+ * @return array<string, mixed>
+ */
+function InputMessageContentInputFileItem(): array
+{
+    return [
+        'type' => 'input_file',
+        'file_data' => 'data:application/pdf;base64,JVBERi0xLjUKJY8KMTgxIDAgb2JqCjw8IC9GaWx0ZXIgL0ZsYXRlRGVjb2RlIC9MZW5ndGggMT...',
+        'file_id' => 'file_0d1b41da7cb4903a0069235a5089408196a847a8f3e7b4fb1c',
+        'filename' => 'file.pdf',
+    ];
+}
+
+/**
+ * @return array<string, mixed>
+ */
+function InputMessageContentInputFileItemMissingOrNull(): array
+{
+    return [
+        'type' => 'input_file',
+        'file_id' => null,
+        'filename' => 'file.pdf',
+    ];
+}
+
 /**
  * @return array<string, mixed>
  */

tests/Responses/Responses/Input/InputMessageContentInputFile.php

@@ -0,0 +1,61 @@
+<?php
+
+use OpenAI\Responses\Responses\Input\InputMessageContentInputFile;
+
+test('from', function () {
+    $response = InputMessageContentInputFile::from(InputMessageContentInputFileItem());
+
+    expect($response)
+        ->toBeInstanceOf(InputMessageContentInputFile::class)
+        ->type->toBe('input_file')
+        ->fileData->toBe('data:application/pdf;base64,JVBERi0xLjUKJY8KMTgxIDAgb2JqCjw8IC9GaWx0ZXIgL0ZsYXRlRGVjb2RlIC9MZW5ndGggMT...')
+        ->fileId->toBe('file_0d1b41da7cb4903a0069235a5089408196a847a8f3e7b4fb1c')
+        ->filename->toBe('file.pdf');
+});
+
+it('is array accessible', function () {
+    $response = InputMessageContentInputFile::from(InputMessageContentInputFileItem());
+
+    expect($response['file_id'])->toBe('file_0d1b41da7cb4903a0069235a5089408196a847a8f3e7b4fb1c');
+});
+
+it('to array', function () {
+    $response = InputMessageContentInputFile::from(InputMessageContentInputFileItem());
+
+    expect($response->toArray())
+        ->toBe([
+            'type' => 'input_file',
+            'file_data' => 'data:application/pdf;base64,JVBERi0xLjUKJY8KMTgxIDAgb2JqCjw8IC9GaWx0ZXIgL0ZsYXRlRGVjb2RlIC9MZW5ndGggMT...',
+            'file_id' => 'file_0d1b41da7cb4903a0069235a5089408196a847a8f3e7b4fb1c',
+            'filename' => 'file.pdf',
+        ]);
+});
+
+test('from (missing or null)', function () {
+    $response = InputMessageContentInputFile::from(InputMessageContentInputFileItemMissingOrNull());
+
+    expect($response)
+        ->toBeInstanceOf(InputMessageContentInputFile::class)
+        ->type->toBe('input_file')
+        ->fileData->toBeNull()
+        ->fileId->toBeNull()
+        ->filename->toBe('file.pdf');
+});
+
+it('is array accessible (missing or null)', function () {
+    $response = InputMessageContentInputFile::from(InputMessageContentInputFileItemMissingOrNull());
+
+    expect($response['file_id'])->toBeNull();
+});
+
+it('to array (missing or null)', function () {
+    $response = InputMessageContentInputFile::from(InputMessageContentInputFileItemMissingOrNull());
+
+    expect($response->toArray())
+        ->toBe([
+            'type' => 'input_file',
+            'file_data' => null,
+            'file_id' => null,
+            'filename' => 'file.pdf',
+        ]);
+});